From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6C4301FF179 for ; Wed, 12 Nov 2025 12:52:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 19AC0A4B; Wed, 12 Nov 2025 12:53:21 +0100 (CET) Message-ID: <74b1b860-b474-46db-b017-7e9a67efa71b@proxmox.com> Date: Wed, 12 Nov 2025 12:52:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: pve-devel@lists.proxmox.com References: <20251112112959.237909-1-f.ebner@proxmox.com> <20251112112959.237909-4-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20251112112959.237909-4-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762948341126 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [timer.pm] Subject: Re: [pve-devel] [PATCH qemu-server 3/3] fix #7014: fix regression starting aarch64 VMs with machine type >= 10.1 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 12.11.25 um 12:30 PM schrieb Fiona Ebner: > diff --git a/src/PVE/QemuServer/Cfg2Cmd/Timer.pm b/src/PVE/QemuServer/Cfg2Cmd/Timer.pm > index 452c15b2..d03715a0 100644 > --- a/src/PVE/QemuServer/Cfg2Cmd/Timer.pm > +++ b/src/PVE/QemuServer/Cfg2Cmd/Timer.pm > @@ -20,9 +20,9 @@ sub generate { > > if ($cfg2cmd->windows_version() >= 6) { > $cfg2cmd->add_global_flag('kvm-pit.lost_tick_policy=discard'); > - $cfg2cmd->add_machine_flag('hpet=off'); > + $cfg2cmd->add_machine_flag_if_supported('hpet', 'off'); Turns out, it was actually a pre-existing issue for the Windows case here even before the introduction of the Cfg2Cmd module, so these patches do not only fix the regression, but that as well :) Shouldn't have relied on pre-existing code to be correct :P > } elsif ($cfg2cmd->is_linux() && $cfg2cmd->version_guard(10, 1, 0)) { > - $cfg2cmd->add_machine_flag('hpet=off'); > + $cfg2cmd->add_machine_flag_if_supported('hpet', 'off'); > } > > $cfg2cmd->add_rtc_flag('driftfix=slew') if $time_drift_fix; _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel