From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 53CD11FF146 for ; Tue, 07 Jul 2026 16:44:33 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B40B92143F; Tue, 07 Jul 2026 16:44:32 +0200 (CEST) Message-ID: <742d03f6-c2db-4053-9088-ba237a730022@proxmox.com> Date: Tue, 7 Jul 2026 16:44:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH manager] postinst: add nbd devices to global lvm filter. To: Daniel Herzig , pve-devel@lists.proxmox.com References: <20260706070306.36846-1-d.herzig@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260706070306.36846-1-d.herzig@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783435462317 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WCVATJTAOYZI5ITV5ETEXQBQVMMYEK7C X-Message-ID-Hash: WCVATJTAOYZI5ITV5ETEXQBQVMMYEK7C X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 06.07.26 um 9:03 AM schrieb Daniel Herzig: > This patch adds nbd-devices to the global filter list of LVM for new Nit: I'd prefer the more explicit "/dev/nbdX devices" or "kernel NBD devices" rather than "nbd-devices". The hyphen makes it seems off IMHO. > installation. s/installation/installations/ > > This is to avoid clashes with existing VGs/LVs on the host system, if > external disks mapped via the nbd kernel driver contain the same > naming scheme (eg. nested Proxmox VE systems with LVM/ext4 s/eg./e.g./ > installation on an LVM/ext4 host). You could add that some external backup solutions use these /dev/nbdX devices, so there are quite a few setups in practice that would benefit. Missing your Signed-off-by. With that added and the comments addressed: Reviewed-by: Fiona Ebner Tested-by: Fiona Ebner > --- > debian/postinst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/postinst b/debian/postinst > index 924e078d..eb7f3356 100755 > --- a/debian/postinst > +++ b/debian/postinst > @@ -26,7 +26,7 @@ set_lvm_conf() { > export LVM_SUPPRESS_FD_WARNINGS=1 > > OLD_VALUE="$(lvmconfig --typeconfig diff devices/global_filter || true)" > - NEW_VALUE='global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]' > + NEW_VALUE='global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|","r|/dev/nbd.*|"]' > > # update global_filter if: > # it is empty and there is no marker OR exactly the one we set before 8.1.4