From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3714F1FF163 for ; Thu, 21 Nov 2024 15:38:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6992E1FDC2; Thu, 21 Nov 2024 15:38:46 +0100 (CET) Message-ID: <73e0f017-062b-44d6-9613-244a32ccf3c8@proxmox.com> Date: Thu, 21 Nov 2024 15:38:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Hannes Laimer References: <20241115100037.25177-1-h.laimer@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20241115100037.25177-1-h.laimer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] fix #3588: helper: consider NIC count for config-specific timeout X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 15.11.24 um 11:00 schrieb Hannes Laimer: > There have been some reports about `qm start` timeouts on VMs that have a > lot of NICs assigned. > This patch considers the number of NICs when calculating the config-specific > timeout. Since the increase in start time is linearly related to the number > of NICs, a constant timeout increment per NIC was chosen. > > Signed-off-by: Hannes Laimer Acked-by: Fiona Ebner > --- > PVE/QemuServer/Helpers.pm | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm > index 0afb6317..99cb3ab8 100644 > --- a/PVE/QemuServer/Helpers.pm > +++ b/PVE/QemuServer/Helpers.pm > @@ -167,6 +167,14 @@ sub config_aware_timeout { > $timeout = 150; > } > > + # Some testing showed that adding a NIC increased the start time by ~450ms > + # consistantly across different NIC models, options and already existsing s/consistantly/consistently/ s/existsing/existing/ > + # number of NICs. > + # So, 10x that to account for any potential system differences seemed > + # reasonable. trailing whitespace here Nit: Maybe also (or alternatively) have a sentence condensing the user reports with some "real-life" values? User in bug report: 20+ -> 40-50 seconds Forum user 1: 25 -> 45 seconds Forum user 2: 17 -> 42 seconds The 5 seconds per NIC seems good in light of those too :) > + my $nic_count = grep { /^net/ } keys %{$config}; I'd also match for the number(s), so we don't match some other future "netXYZ" option. E.g. "net-defaults" is on the radar (i.e. in a branch of mine :P) already for the future guest profiles feature. Nit: I'd prefer having an explicit scalar() in such cases. > + $timeout += $nic_count * 5; > + > return $timeout; > } > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel