From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6523598DB for ; Fri, 18 Nov 2022 10:48:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4529F3663F for ; Fri, 18 Nov 2022 10:47:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 18 Nov 2022 10:47:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 207A044945; Fri, 18 Nov 2022 10:47:56 +0100 (CET) Message-ID: <73c2a7e4-0758-2b42-c724-259416396f3f@proxmox.com> Date: Fri, 18 Nov 2022 10:47:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 To: Proxmox VE development discussion , John Hollowell References: <20221118013911.2655-1-jhollowe@johnhollowell.com> Content-Language: en-US From: Matthias Heiserer In-Reply-To: <20221118013911.2655-1-jhollowe@johnhollowell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.187 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF =?UTF-8?Q?record=0A=09?=URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [anyevent.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH v2 http-server 0/2] fix #4344: ignore unused multipart headers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2022 09:48:27 -0000 Reviewed-by: Matthias Heiserer On 18.11.2022 02:39, John Hollowell wrote: > This fixes an issue where an upload request without a Content-Type in > the file's multipart part would prevent the upload and throw > missleading errors. This patch removes the requirement and ignores > all multipart headers once the needed information has been extracted. > > I have tested these changes against a 7.2-11 server and both a previously > broken upload method (without the Content-Type) and using the webUI in > Chrome (which includes a Content-Type) correctly uploads the file. > > Changes since v1: > * remove `xx` and escaping of spaces from regex > > John Hollowell (2): > fix #4344: http-server: ignore unused multipart headers > Remove whitespace ignore from regex > > src/PVE/APIServer/AnyEvent.pm | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > -- > 2.30.2 > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >