From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6CC5862D84 for ; Fri, 18 Sep 2020 14:36:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 54144161A1 for ; Fri, 18 Sep 2020 14:36:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8383016197 for ; Fri, 18 Sep 2020 14:36:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4974845428 for ; Fri, 18 Sep 2020 14:36:15 +0200 (CEST) To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20200917111658.1358831-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht Message-ID: <73b5ea4b-443a-d538-59bb-ded019d11ce7@proxmox.com> Date: Fri, 18 Sep 2020 14:36:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Thunderbird/81.0 MIME-Version: 1.0 In-Reply-To: <20200917111658.1358831-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.192 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, cliformatter.pm] Subject: [pve-devel] applied: Re: [PATCH common] properly encode YAML via YAML::XS X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 12:36:16 -0000 On 9/17/20 1:16 PM, Fabian Grünbichler wrote: > otherwise we get strange errors when formatting data that was originally > JSON, and can thus contain JSON::true/JSON::false. > > one example is the QMP query-blockstats command, which gets called (and > the resulting values returned) by /nodes/NODE/qemu/VMID/status/current > > Signed-off-by: Fabian Grünbichler > --- > > Notes: > alternatives include: > - dropping --output-format yaml altogether > - manually recursively mapping JSON::true/false to some sensible value before dumping > - outputting JSON instead of YAML, since the former is a subset of the latter (thanks Dominik ;)) > > https://forum.proxmox.com/threads/yaml-issues-with-pvesh.76017/ > > debian/control | 1 + > src/PVE/CLIFormatter.pm | 7 ++++--- > 2 files changed, 5 insertions(+), 3 deletions(-) > > applied, thanks!