Re: [PATCH manager] sdn: fabrics: disable prefix editing when nodes exist

[Hannes Laimer <h.laimer@proxmox.com>]

Tested-by: Hannes Laimer <h.laimer@proxmox.com>

On 2026-05-20 17:12, Gabriel Goller wrote:
> Do not allow editing the fabric IPv4 or IPv6 prefix while the fabric
> still has configured nodes. The API will throw an error, but this
> improves the UX.
> 
> Suggested-by: Hannes Laimer <h.laimer@proxmox.com>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  www/manager6/sdn/FabricsView.js        | 5 +++++
>  www/manager6/sdn/fabrics/FabricEdit.js | 4 ++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/www/manager6/sdn/FabricsView.js b/www/manager6/sdn/FabricsView.js
> index f2b8456a7720..88926462df11 100644
> --- a/www/manager6/sdn/FabricsView.js
> +++ b/www/manager6/sdn/FabricsView.js
> @@ -310,6 +310,10 @@ Ext.define('PVE.sdn.Fabric.View', {
>              return prefix === 'deleted' ? undefined : prefix;
>          },
>  
> +        fabricHasConfiguredNodes: function (fabric) {
> +            return (fabric.children ?? []).some((node) => node.state !== 'deleted');
> +        },
> +
>          addWireGuard: function () {
>              let me = this;
>              me.openFabricAddWindow('wireguard');
> @@ -406,6 +410,7 @@ Ext.define('PVE.sdn.Fabric.View', {
>              let window = Ext.create(component, {
>                  autoShow: true,
>                  fabricId: fabric.id,
> +                disableIpPrefixEdit: me.fabricHasConfiguredNodes(fabric),
>              });
>  
>              window.on('destroy', () => me.reload());
> diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js
> index 740719b1cc62..ddecbdc83df3 100644
> --- a/www/manager6/sdn/fabrics/FabricEdit.js
> +++ b/www/manager6/sdn/fabrics/FabricEdit.js
> @@ -9,6 +9,8 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
>      hasIpv4Support: true,
>      hasIpv6Support: true,
>  
> +    disableIpPrefixEdit: false,
> +
>      baseUrl: '/cluster/sdn/fabrics/fabric',
>  
>      viewModel: {
> @@ -60,6 +62,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
>                  fieldLabel: gettext('IPv4 Prefix'),
>                  labelWidth: 120,
>                  name: 'ip_prefix',
> +                disabled: me.disableIpPrefixEdit,
>                  allowBlank: me.hasIpv6Support,
>                  vtype: 'IPCIDRAddress',
>                  skipEmptyText: true,
> @@ -82,6 +85,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
>                      fieldLabel: gettext('IPv6 Prefix'),
>                      labelWidth: 120,
>                      name: 'ip6_prefix',
> +                    disabled: me.disableIpPrefixEdit,
>                      allowBlank: true,
>                      vtype: 'IP6CIDRAddress',
>                      skipEmptyText: true,