From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 153579B49E for ; Mon, 20 Nov 2023 16:05:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E8EFC1B981 for ; Mon, 20 Nov 2023 16:05:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 20 Nov 2023 16:05:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A32DF434D7; Mon, 20 Nov 2023 16:05:17 +0100 (CET) Message-ID: <733271a0-5477-41d8-b7df-c02ce6362b90@proxmox.com> Date: Mon, 20 Nov 2023 16:05:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Content-Language: en-US To: Proxmox VE development discussion , Fiona Ebner References: <20231120145356.184383-1-f.ebner@proxmox.com> From: Dominik Csapak In-Reply-To: <20231120145356.184383-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit] notification matcher: fix inverted match modes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2023 15:05:19 -0000 yes, this fixes setting/loading the inverted modes it seems i have sent a hunk too much with my followup thanks for fixing! Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 11/20/23 15:53, Fiona Ebner wrote: > The 'not' prefix is already stripped in the set() method of the view > model's 'rootMode' and not present anymore when updating the store. > The information about whether the mode is inverted or not is present > in the 'invert' data member. > > Signed-off-by: Fiona Ebner > --- > src/window/NotificationMatcherEdit.js | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js > index 5a88288..ee08c16 100644 > --- a/src/window/NotificationMatcherEdit.js > +++ b/src/window/NotificationMatcherEdit.js > @@ -778,12 +778,8 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', { > matchCalendarStmts.push(data.value); > break; > case 'mode': > - if (data.value.startsWith('not')) { > - modeStmt = data.value.substring(3); // after 'not'' > - invertMatchStmt = true; > - } else { > - modeStmt = data.value; > - } > + modeStmt = data.value; > + invertMatchStmt = data.invert; > break; > } >