From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5EA6D7C393 for <pve-devel@lists.proxmox.com>; Thu, 4 Nov 2021 15:40:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4D856220B4 for <pve-devel@lists.proxmox.com>; Thu, 4 Nov 2021 15:40:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4FACF220A4 for <pve-devel@lists.proxmox.com>; Thu, 4 Nov 2021 15:40:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E3E2346A75; Thu, 4 Nov 2021 15:40:12 +0100 (CET) Message-ID: <72eea614-c01b-5d94-b872-626dc1ca9b3f@proxmox.com> Date: Thu, 4 Nov 2021 15:40:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Lorenz Stechauner <l.stechauner@proxmox.com> References: <20211022122312.413252-1-l.stechauner@proxmox.com> From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <20211022122312.413252-1-l.stechauner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.528 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [storage.pm, status.pm, aplinfo.pm, plugin.pm] Subject: Re: [pve-devel] [PATCH-SERIES v3 storage/manager] factoring out RE for backup extension X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 04 Nov 2021 14:40:44 -0000 Series LGTM, looked closely at the regexes, and they match (semantically), tested around a bit and all seemed to work. one super small nit (not a blocker IMHO) the format/extension/compression handling in 2/2 could maybe use a comment what we do there (though maybe it's just me who's confused ^^) On 10/22/21 14:23, Lorenz Stechauner wrote: > changes to v2: > * rebased to current master > * kept old $vztmpl_extension_re to not break pve-manager and added > # FIXME [...] > > changes to v1: > * also renamed iso/vztmpl REs > * new naming schema: $<X>_EXT_RE_<# of capture groups> > for example: $BACKUP_EXT_RE_2 > > pve-storage > Lorenz Stechauner (2): > storage: rename REs for iso and vztmpl extensions > storage/plugin: factoring out regex for backup extension re > > PVE/API2/Storage/Status.pm | 8 ++++---- > PVE/Storage.pm | 26 +++++++++++++++++--------- > PVE/Storage/Plugin.pm | 12 ++++++------ > 3 files changed, 27 insertions(+), 19 deletions(-) > > > pve-manager: > Lorenz Stechauner (1): > api: aplinfo: rename REs for iso and vztmpl extensions > > PVE/APLInfo.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >