From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E6E92697E9 for ; Thu, 24 Mar 2022 12:09:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D57BC2F07D for ; Thu, 24 Mar 2022 12:08:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4290B2F071 for ; Thu, 24 Mar 2022 12:08:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0A1E046410 for ; Thu, 24 Mar 2022 12:08:53 +0100 (CET) Message-ID: <71e9f2db-9525-d45f-6a98-1f72aab198ce@proxmox.com> Date: Thu, 24 Mar 2022 12:08:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20220314093509.349554-1-a.lauterer@proxmox.com> <20220314093509.349554-4-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220314093509.349554-4-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v4 manager 3/6] ui: lxc/qemu: disk/volume action simplify menu items X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 11:09:24 -0000 On 14.03.22 10:35, Aaron Lauterer wrote: > We already know that we are acting upon a disk / volume due to the > submenu we are in. ok with that in general, but some proposal over conveying better what "move" and "reassign" respectively means while not getting a long label. Also, a (separate) suggestions for possible icons. > > Signed-off-by: Aaron Lauterer > --- > www/manager6/lxc/Resources.js | 6 +++--- > www/manager6/qemu/HardwareView.js | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js > index 4d47679d..a456fdf2 100644 > --- a/www/manager6/lxc/Resources.js > +++ b/www/manager6/lxc/Resources.js > @@ -202,7 +202,7 @@ Ext.define('PVE.lxc.RessourceView', { > }); > > let resize_menuitem = new Ext.menu.Item({ > - text: gettext('Resize disk'), > + text: gettext('Resize'), + fa-plus icon > selModel: me.selModel, > disabled: true, > handler: run_resize, > @@ -247,7 +247,7 @@ Ext.define('PVE.lxc.RessourceView', { > }); > > let reassign_menuitem = new Ext.menu.Item({ > - text: gettext('Reassign Volume'), > + text: gettext('Reassign'), "Reassign Owner" + LXC box icon > tooltip: gettext('Reassign volume to another CT'), > handler: run_reassign, > reference: 'reassing_item', > @@ -255,7 +255,7 @@ Ext.define('PVE.lxc.RessourceView', { > }); > > let move_menuitem = new Ext.menu.Item({ > - text: gettext('Move Volume'), > + text: gettext('Move'), "Move Storage" + arrow-right icon > selModel: me.selModel, > disabled: true, > handler: run_move, > diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js > index af84fb3f..3da7499d 100644 > --- a/www/manager6/qemu/HardwareView.js > +++ b/www/manager6/qemu/HardwareView.js > @@ -443,20 +443,20 @@ Ext.define('PVE.qemu.HardwareView', { > }); > > let resize_menuitem = new Ext.menu.Item({ > - text: gettext('Resize disk'), > + text: gettext('Resize'), + fa-plus icon > selModel: sm, > disabled: true, > handler: run_resize, > }); > > let move_menuitem = new Ext.menu.Item({ > - text: gettext('Move disk'), > + text: gettext('Move'), "Move Storage" + arrow-right icon > selModel: sm, > handler: run_move, > }); > > let reassign_menuitem = new Ext.menu.Item({ > - text: gettext('Reassign Disk'), > + text: gettext('Reassign'), "Reassign Owner" + VM "display" icon > tooltip: gettext('Reassign disk to another VM'), > handler: run_reassign, > selModel: sm,