From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 4F7DD1FF17C
	for <inbox@lore.proxmox.com>; Wed, 25 Jun 2025 14:54:14 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 62A31149E9;
	Wed, 25 Jun 2025 14:54:47 +0200 (CEST)
Message-ID: <71d420bd-6087-418b-ac4d-16fdad2fc08c@proxmox.com>
Date: Wed, 25 Jun 2025 14:54:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Fiona Ebner <f.ebner@proxmox.com>
References: <20250623154433.449277-1-f.ebner@proxmox.com>
 <20250623154433.449277-7-f.ebner@proxmox.com>
Content-Language: en-US
From: Daniel Kral <d.kral@proxmox.com>
In-Reply-To: <20250623154433.449277-7-f.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.012 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server 06/15] introduce QemuImage module
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 6/23/25 17:44, Fiona Ebner wrote:
> diff --git a/src/PVE/QemuServer/ImportDisk.pm b/src/PVE/QemuServer/ImportDisk.pm
> index 8ecd5521..01289fc5 100755
> --- a/src/PVE/QemuServer/ImportDisk.pm
> +++ b/src/PVE/QemuServer/ImportDisk.pm
> @@ -4,9 +4,11 @@ use strict;
>   use warnings;
>   
>   use PVE::Storage;
> -use PVE::QemuServer;
>   use PVE::Tools qw(run_command extract_param);
>   
> +use PVE::QemuServer;
> +use PVE::QemuServer::QemuImage;
> +
>   # imports an external disk image to an existing VM
>   # and creates by default a drive entry unused[n] pointing to the created volume
>   # $params->{drive_name} may be used to specify ide0, scsi1, etc ...
> @@ -82,7 +84,7 @@ sub do_import {
>               local $SIG{PIPE} = sub { die "interrupted by signal $!\n"; };
>   
>           PVE::Storage::activate_volumes($storecfg, [$dst_volid]);
> -        PVE::QemuServer::qemu_img_convert(
> +        PVE::QemuImage::convert(
>               $src_path,
>               $dst_volid,
>               $src_size,

Just noticed while doing a import-from=... that here the ::QemuServer 
was missing, sent a quick patch [0] to fix it :)

[0] 
https://lore.proxmox.com/pve-devel/20250625125039.153187-1-d.kral@proxmox.com/


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel