From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 32E1C6D586 for ; Thu, 1 Apr 2021 12:22:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 22EC71A430 for ; Thu, 1 Apr 2021 12:22:09 +0200 (CEST) Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A6EA81A428 for ; Thu, 1 Apr 2021 12:22:08 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id v4so1242497wrp.13 for ; Thu, 01 Apr 2021 03:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=dHamyfa3FAPYYf5A9nHe3HPyrNOgiuYV8Ev3jZzl/1k=; b=1pOBaDz7clrdXT8QqqfQoP1kO6lS3yZ0ZppnluNq8VmRMejoIka+Dk1/wZPBjIIuA4 I50UCalfAUstGEhAZZSOAwGllhVqaJz2Wbleb/1Y+DvsF1QaA88wvVM+CssWGrjx3Pq2 LUEou1h0WdBVFDh/+P3tof+5z0JwYgiCwlogA9H1iF96F3s7FGLiNjpkItg1cVrErqdA ARTjDjx832kKDmxtxZsWJX9hwJkbxjdbIhrn/W8q9SPjT4OygMevq+2HLAks1pNvkl3F UVWGWp4vQWbr97LbBcy9FcKZtoMLTvIPfvanr24k64ne9JK9Cq2yHvf1LCfiTnZNirTI LEig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=dHamyfa3FAPYYf5A9nHe3HPyrNOgiuYV8Ev3jZzl/1k=; b=i/q7JZM4JoI4HyzsiD79F8J770r0n0yHEYEEaedF/C/r1U4q5tGd7ys+19eUF98Igd qbhUmHzVIlPEldMNjC9daW6Y3AWMWys9iisYm3Zp4d4/u0oUGxmks0STcoRQNtKqtXGe sb7wKOVAxofdwaayErwQdeEgXBM/58+0VJQ47a1t2jvtEKEnyBA+w8/9iz9r1aUU6Aho O7OWWoNH6GOyIgwAsai8WbypJ7AAlxelPDggfE/iDXo4bHAeLfvb2JQtSnIaQykxUgfc OAUt/iU36ixqXAuNaBRS6QwUeBBB0py3NMKbkDCm2Bg64v64ufM611QxsQlQPM/NjL+3 NEUQ== X-Gm-Message-State: AOAM533unFh+LQM1BwLU+dUprkWgRg61aa1urX52McFQ8oTMwBLCV47Q 8uQwM+5lFupZ+FORMW/LoH3EiOtZMPBYSuq7X8Y= X-Google-Smtp-Source: ABdhPJxduQcUoAWpGW0zSMgTjMuefcQ6o0Oxeber8YGOuP3HIdmFE/KMZDFeqLWkCakpuXGhigeRLg== X-Received: by 2002:adf:82aa:: with SMTP id 39mr9002824wrc.114.1617272522420; Thu, 01 Apr 2021 03:22:02 -0700 (PDT) Received: from [10.59.100.76] (globalOdiso.M6Lille.odiso.net. [89.248.211.242]) by smtp.gmail.com with ESMTPSA id u9sm7376209wmc.38.2021.04.01.03.22.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 03:22:02 -0700 (PDT) Message-ID: <716d60aa36860a8ed739cd45af8c5bfd99bf973e.camel@odiso.com> From: aderumier@odiso.com To: Thomas Lamprecht , Proxmox VE development discussion Date: Thu, 01 Apr 2021 12:22:01 +0200 In-Reply-To: <93b9f005-6922-5903-31a9-a72ea6fc7d49@proxmox.com> References: <20210328151203.2063706-1-aderumier@odiso.com> <20210328151203.2063706-2-aderumier@odiso.com> <93b9f005-6922-5903-31a9-a72ea6fc7d49@proxmox.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.853 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 10:22:39 -0000 Le jeudi 01 avril 2021 à 10:54 +0200, Thomas Lamprecht a écrit : > > actually, why isn't the pending section enough for this? > > If stuff can be hot plugged then we can do so and if only that > changed we > can just remove it from pending, as normally? Well, for example, if you change the vm name , how to you manage that ? do you want to keep it as pending  until we regenerate cloudinit drive? or more complex, if you change the mac address of the vm. (so unplug/replug the nic) for the nic, you don't want to keep it as pending, as technically, is really plugged. or if you change the storage of the cloudinit drive, currently they a no way to known if we need to regenerate it. The main problem is that pending section, is more for pending qemu change, not pending cloudinit config drive regeneration. For me, both are differents. Currently,it's working well when vm is offline, because we don't have any pending, and we regenerate the disk at vm startup. (I'm really looking to use cloudinit for online config changes, like for containers)