From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 555C06A7C0 for <pve-devel@lists.proxmox.com>; Wed, 16 Mar 2022 17:17:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4404529DA9 for <pve-devel@lists.proxmox.com>; Wed, 16 Mar 2022 17:16:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 26A4129D9C for <pve-devel@lists.proxmox.com>; Wed, 16 Mar 2022 17:16:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E3C4641E11 for <pve-devel@lists.proxmox.com>; Wed, 16 Mar 2022 17:16:41 +0100 (CET) Message-ID: <7113586c-a599-126a-afce-6a71dd2aabde@proxmox.com> Date: Wed, 16 Mar 2022 17:16:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20211022122312.413252-1-l.stechauner@proxmox.com> <72eea614-c01b-5d94-b872-626dc1ca9b3f@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <72eea614-c01b-5d94-b872-626dc1ca9b3f@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH-SERIES v3 storage/manager] factoring out RE for backup extension X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 16 Mar 2022 16:17:13 -0000 On 04.11.21 15:40, Dominik Csapak wrote: > Series LGTM, looked closely at the regexes, > and they match (semantically), tested around a bit > and all seemed to work. > > one super small nit (not a blocker IMHO) > > the format/extension/compression handling in 2/2 > could maybe use a comment what we do there > (though maybe it's just me who's confused ^^) > can you send a follow up with what you have in mind? > On 10/22/21 14:23, Lorenz Stechauner wrote: >> changes to v2: >> * rebased to current master >> * kept old $vztmpl_extension_re to not break pve-manager and added >> # FIXME [...] >> >> changes to v1: >> * also renamed iso/vztmpl REs >> * new naming schema: $<X>_EXT_RE_<# of capture groups> >> for example: $BACKUP_EXT_RE_2 >> >> pve-storage >> Lorenz Stechauner (2): >> storage: rename REs for iso and vztmpl extensions >> storage/plugin: factoring out regex for backup extension re >> >> PVE/API2/Storage/Status.pm | 8 ++++---- >> PVE/Storage.pm | 26 +++++++++++++++++--------- >> PVE/Storage/Plugin.pm | 12 ++++++------ >> 3 files changed, 27 insertions(+), 19 deletions(-) applied the storage part, thanks!