From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 89DB061759
 for <pve-devel@lists.proxmox.com>; Thu,  9 Jul 2020 14:12:11 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 7769512145
 for <pve-devel@lists.proxmox.com>; Thu,  9 Jul 2020 14:12:11 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 114751213B
 for <pve-devel@lists.proxmox.com>; Thu,  9 Jul 2020 14:12:11 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C44D842314;
 Thu,  9 Jul 2020 14:12:10 +0200 (CEST)
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 =?UTF-8?Q?Fabian_M=c3=b6ller?= <fabianm88@gmail.com>
References: <20200708084242.555-1-fabianm88@gmail.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <700923bb-4c96-f2b6-6508-911d3d0ae1ee@proxmox.com>
Date: Thu, 9 Jul 2020 14:12:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.0
MIME-Version: 1.0
In-Reply-To: <20200708084242.555-1-fabianm88@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results:  0
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] applied: Re: [PATCH widget-toolkit] Add focusable
 pseudo class to edit windows defaultFocus
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2020 12:12:11 -0000

On 08.07.20 10:42, Fabian M=C3=B6ller wrote:
> Restricting the defaultFocus of the edit windows to only focusable fiel=
ds
> ensures that windows like "PVE -> Virtual Machine -> Manage HA", which
> has a first field of xtype "displayfield", receive focus upon opening.
>=20
> This allows those windows to be closed with the ESC key, which only
> works when an element inside has focus.
>=20
> In newer versions of ExtJS (>=3D 6.2.0) this filter could be reduced to=

> "field:canfocus" or maybe even ":canfocus".
> ---
>  src/window/Edit.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
>

applied, thanks!