From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 56A31BBF82 for ; Wed, 20 Dec 2023 14:20:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3DD1DD417 for ; Wed, 20 Dec 2023 14:20:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 20 Dec 2023 14:20:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 802BA4876C for ; Wed, 20 Dec 2023 14:20:16 +0100 (CET) Message-ID: <7008ded8-ba57-4d59-8796-f97d53d36851@proxmox.com> Date: Wed, 20 Dec 2023 14:20:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Content-Language: en-GB To: Proxmox VE development discussion , Friedrich Weber References: <20231219092227.48384-1-f.weber@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20231219092227.48384-1-f.weber@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH ifupdown2] fix #5009: avoid waiting for stdout eof of /etc/network/ scripts X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2023 13:20:48 -0000 On 19/12/2023 10:22, Friedrich Weber wrote: > Previously, PVE (7 and 8) hosts would hang at boot if both ntpsec and > ntpsec-ntpdate are installed. The root cause for the hang is an > unfortunate interaction between ntpsec, ntpsec-ntpdate and the PVE > ifupdown2 package. The hang happens because ntpsec-ntpdate installs a > hook /etc/network/if-up.d/ntpsec-ntpdate that blocks until networking > is available if ntpsec is installed. Previously, ifupdown2 would wait > for the hook to terminate, so networking would never become available, > resulting in a deadlock. See the bug report [0] for more information. > > With this patch, ifupdown2 runs the hook in the background and does > not wait for it to terminate, thus resolving the deadlock. > > This patch was already applied upstream [1]. Backport it to make it > available before the next upstream release. > > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5009 > [1] https://github.com/CumulusNetworks/ifupdown2/pull/274 > > Signed-off-by: Friedrich Weber > --- > > Notes: > Tested on PVE 8: > * installed ntpsec and ntpsec-ntpdate > reboot without `quiet` -> boot hangs at networking > * installed patched ifupdown2, ntpsec, ntpsec-ntpdate > reboot -> boot ok > > debian/patches/series | 1 + > ...waiting-for-stdout-eof-of-etc-networ.patch | 44 +++++++++++++++++++ > 2 files changed, 45 insertions(+) > create mode 100644 debian/patches/upstream/0001-scheduler-avoid-waiting-for-stdout-eof-of-etc-networ.patch > > applied, thanks!