From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 440F21FF2AD
	for <inbox@lore.proxmox.com>; Wed,  3 Jul 2024 10:27:27 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 841B1350F;
	Wed,  3 Jul 2024 10:27:42 +0200 (CEST)
Date: Wed, 3 Jul 2024 10:27:39 +0200
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Message-ID: <6wfp67mgioh4t5proo3h2ro4kiplqxxbg5eplvp6hdlceazl34@ptaatpvue5cc>
References: <mailman.484.1717758081.319.pve-devel@lists.proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <mailman.484.1717758081.319.pve-devel@lists.proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.087 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [syscall.pm, tools.pm]
Subject: [pve-devel] applied: [PATCH pve-common] tools: fix syscall mknod()
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Jing Luo <jing@jing.rocks>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

applied, thanks

Interesting how this seems to break on other architectures...

On Fri, Jun 07, 2024 at 06:33:13PM GMT, Jing Luo via pve-devel wrote:
> From: Jing Luo <jing@jing.rocks>
> To: pve-devel@lists.proxmox.com
> Cc: Jing Luo <jing@jing.rocks>
> Subject: [PATCH pve-common] tools: fix syscall mknod()
> Date: Fri,  7 Jun 2024 18:33:13 +0900
> Message-ID: <20240607093933.3882526-2-jing@jing.rocks>
> X-Mailer: git-send-email 2.45.2
> 
> b792e8df81 introduced a bug that can cause this:
> 
> Undefined subroutine &PVE::Syscall::SYS_mknod called at /usr/share/perl5/PVE/Syscall.pm line 11
> 
> It should be mknod, not SYS_mknod. This caused other pve perl lib failing
> to build. I couldn't reproduce this on amd64 build, but I could reproduce this
> on arm64 build; however this didn't seem to fix the issue, unless I revert
> b792e8df81.
> 
> cf: b792e8df81d70cc8fc4bc7d0655313d4a7f40c3d
> Signed-off-by: Jing Luo <jing@jing.rocks>
> ---
>  src/PVE/Tools.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
> index 766c809..c2906de 100644
> --- a/src/PVE/Tools.pm
> +++ b/src/PVE/Tools.pm
> @@ -1753,7 +1753,7 @@ sub mkdirat($$$) {
>  
>  sub mknod($$$) {
>      my ($filename, $mode, $dev) = @_;
> -    return syscall(PVE::Syscall::SYS_mknod, $filename, int($mode), int($dev)) == 0;
> +    return syscall(PVE::Syscall::mknod, $filename, int($mode), int($dev)) == 0;
>  }
>  
>  sub fchownat($$$$$) {
> -- 
> 2.45.2


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel