From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 108F41FF15E
for <inbox@lore.proxmox.com>; Tue, 8 Apr 2025 13:27:25 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id A3D101A29A;
Tue, 8 Apr 2025 13:27:22 +0200 (CEST)
Date: Tue, 8 Apr 2025 13:27:20 +0200
From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <6rpik5dt6xzeobbs3k6ae3iyiugsbl2qgw2lnssk4rdari5gs6@htn6nwd2oyal>
Mail-Followup-To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
References: <20250108143812.241488-1-g.goller@proxmox.com>
<20250108143812.241488-2-g.goller@proxmox.com>
<9ee6e2b0-7918-43a0-827c-314121b3fa42@proxmox.com>
<u5kwnee4d2exxtqvjxu4y5ezug4qyk66wf3psssu7nj5a4p6ny@tyzwyelzqfkm>
<117cb783-e591-48ef-b196-3c4089db95fe@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <117cb783-e591-48ef-b196-3c4089db95fe@proxmox.com>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.171 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
POISEN_SPAM_PILL 0.1 Meta: its spam
POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes
POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically
assigned IPs in network tab
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 08.04.2025 12:18, Thomas Lamprecht wrote:
>Am 08.04.25 um 12:06 schrieb Gabriel Goller:
>> On 07.04.2025 19:46, Thomas Lamprecht wrote:
>>> Am 08.01.25 um 15:38 schrieb Gabriel Goller:
>>>> adds a call to /nodes/{node}/lxc/{vmid}/interfaces and merges the
>>>> returned data with the existing configuration. This will update the
>>>> IPv4 and IPv6 address, as well as the interface name (in case the
>>>> container changed it).
>>>>
>>>> Originally-by: Leo Nunner <l.nunner@proxmox.com>
>>>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>>>> ---
>>>> www/manager6/lxc/Network.js | 85 ++++++++++++++++++++++++++-----------
>>>> 1 file changed, 60 insertions(+), 25 deletions(-)
>>>>
>>>
>>> the network view's grid gets broken here for any container that is not
>>> turned on, and thus cannot have an address configured.
>>
>> Umm this is kinda tricky, the proxmoxRRDChart has a fixed height of 300,
>> and changing that probably breakes a lot of stuff. I could make the
>> GuestView (so the first panel) scrollable, but then additional text or
>> the "More" button will probably be cut off (when not scrolling).
>
>There are no RRD graphs in the network view, what are you talking about?
>I mean the columns of the network configuration view stop rendering with
>these patches starting from the address column rightwards.
Oh, I'm stupid, I thought of the grid in the GuestSummary "IPs"
property.
Anyway, fixed the problem you reported.
The problem I mentioned still exists, although it isn't really that bad.
I added the IP addresses and a "More" button to the Container Summary
and increased it's height, so as to make room for it. This make
everything look kinda weird (i.e., the GuestSummary panel is higher than
the CPU usage RRD graph.) But as I said, we could make it scrollable?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel