From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 72FDB1FF166 for ; Fri, 8 Nov 2024 10:29:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4CCFCA294; Fri, 8 Nov 2024 10:29:10 +0100 (CET) Date: Fri, 8 Nov 2024 10:28:36 +0100 From: Christoph Heiss To: Aaron Lauterer Message-ID: <6puwldfczbsxkh7etz5pn2dgyaaodt3yg6rxuafud3jeqv3cp4@7pfyraxjjpxq> References: <20241018115943.813243-1-c.heiss@proxmox.com> <20241018115943.813243-5-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [partition.rs] Subject: Re: [pve-devel] [PATCH installer 4/4] fetch-answer: use partition label from fetch config instead of hardcoded X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thanks for the review! On Thu, Nov 07, 2024 at 04:28:25PM +0100, Aaron Lauterer wrote: > only small nits inline > > Tested-By: Aaron Lauterer > Reviewed-By: Aaron Lauterer > > On 2024-10-18 13:59, Christoph Heiss wrote: > > [..] > > diff --git a/proxmox-fetch-answer/src/fetch_plugins/partition.rs b/proxmox-fetch-answer/src/fetch_plugins/partition.rs > > index cbfe2d5..c68dc59 100644 > > --- a/proxmox-fetch-answer/src/fetch_plugins/partition.rs > > +++ b/proxmox-fetch-answer/src/fetch_plugins/partition.rs > > @@ -9,17 +9,16 @@ use std::{ > > static ANSWER_FILE: &str = "answer.toml"; > > static ANSWER_MP: &str = "/mnt/answer"; > > // FAT can only handle 11 characters, so shorten Automated Installer Source to AIS > > this comment is now dangling. we could move that to the definition of the > default value for the new parameter Yep, good catch! Also, while reading this, seems nowhere is checked whether the user-supplied value is at max 11 characters long -- I'll add that for v2 too. > > [..] > > @@ -74,14 +73,14 @@ fn scan_partlabels(partlabel: &str, search_path: &str) -> Result { > > bail!("Could not find partition for label '{partlabel}'"); > > } > > -/// Will search and mount a partition/FS labeled PARTLABEL (proxmox-ais) in lower or uppercase > > -/// to ANSWER_MP > > -fn mount_proxmoxinst_part() -> Result { > > +/// Will search and mount a partition/FS labeled labeled `part_label` in lower or uppercase to > > one `labeled` too much :) Thx! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel