From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9393F69FA9 for ; Tue, 11 Aug 2020 10:16:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E28C1ABF0 for ; Tue, 11 Aug 2020 10:15:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EC7C11ABE6 for ; Tue, 11 Aug 2020 10:15:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B2CF144531 for ; Tue, 11 Aug 2020 10:15:30 +0200 (CEST) To: Fabian Ebner , pve-devel@lists.proxmox.com References: <20200810145709.5629-1-a.lauterer@proxmox.com> <532dc0d2-8365-3ba6-144e-ac2c4779f92c@proxmox.com> From: Aaron Lauterer Message-ID: <6fdd4308-ed9d-57f7-5734-6e141154312c@proxmox.com> Date: Tue, 11 Aug 2020 10:15:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.1.1 MIME-Version: 1.0 In-Reply-To: <532dc0d2-8365-3ba6-144e-ac2c4779f92c@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.044 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: Re: [pve-devel] [PATCH container] lxc: resize: fix #2790 return message in case of disk already at size X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2020 08:16:01 -0000 On 8/11/20 9:51 AM, Fabian Ebner wrote: > The returned string is supposed to be a task ID. If some other kind of string is returned, could this cause any problems? Good point. Maybe it is better then to die instead of returning so the returned values will not contain a "success". Return message on a successfull resize is {"success":1,"data":"UPID:nola:00000B3B:0425A0CD:5F3251DC:resize:300:root@pam:"} When setting the size to a smaller value, where we die: {"message":"unable to shrink disk size\n","data":null,"success":0,"status":500} > > Am 10.08.20 um 16:57 schrieb Aaron Lauterer: >> Otherwise the API would return an error message because the schema >> defines a return of type string which wasn't provided. >> >> Signed-off-by: Aaron Lauterer >> --- >> >> We should probably align the resize endpoint on the qemu side >> accordingly. >> >>   src/PVE/API2/LXC.pm | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm >> index 21899d0..bcac8e2 100644 >> --- a/src/PVE/API2/LXC.pm >> +++ b/src/PVE/API2/LXC.pm >> @@ -1674,7 +1674,7 @@ __PACKAGE__->register_method({ >>           die "unable to shrink disk size\n" if $newsize < $size; >> -        return if $size == $newsize; >> +        return 'disk is already at specified size' if $size == $newsize; >>           PVE::Cluster::log_msg('info', $authuser, "update CT $vmid: resize --disk $disk --size $sizestr"); >>           my $realcmd = sub { >>