From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B1AD81FF140 for ; Fri, 27 Mar 2026 10:57:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F393C2111; Fri, 27 Mar 2026 10:57:55 +0100 (CET) Message-ID: <6f99798a-3b4b-49eb-a62f-b253350eb55d@proxmox.com> Date: Fri, 27 Mar 2026 10:57:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network 05/13] api2: add route maps api module To: Hannes Laimer , pve-devel@lists.proxmox.com References: <20260325094142.174364-1-s.hanreich@proxmox.com> <20260325094142.174364-20-s.hanreich@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.562 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BYEU5K4LHVPD3R7KRWEOLUJLMANJNFSL X-Message-ID-Hash: BYEU5K4LHVPD3R7KRWEOLUJLMANJNFSL X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/26/26 4:04 PM, Hannes Laimer wrote: > On 2026-03-25 10:44, Stefan Hanreich wrote: >> Contains the following API endpoints: >> >> GET /route-maps - lists all route map entries >> POST /route-maps - creates a new route map entry >> >> The following commits contain the API modules for accessing specific >> route maps / route map entries. >> >> Signed-off-by: Stefan Hanreich >> --- > > [..] > >> +__PACKAGE__->register_method({ >> + name => 'list_route_maps', >> + path => '', >> + method => 'GET', >> + permissions => { >> + description => >> + "Only returns route map entries where you have 'SDN.Audit' or 'SDN.Allocate' permissions.", >> + }, >> + description => "List Route Maps", > > [..] > >> + code => sub { >> + my ($param) = @_; >> + >> + my $pending = extract_param($param, 'pending'); >> + my $running = extract_param($param, 'running'); >> + >> + my $digest; >> + my $route_maps; >> + >> + if ($pending) { >> + my $current_config = PVE::Network::SDN::RouteMaps::config()->list(); >> + my $running_config = PVE::Network::SDN::RouteMaps::config(1)->list(); >> + >> + my $pending_route_maps = PVE::Network::SDN::pending_config( >> + $running_config, >> + $current_config, > > we should wrap these two, as on pve-network 3/13 fixed in the same vein as 3/13