From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BC32E61131 for ; Mon, 17 Aug 2020 09:09:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A6D232EB05 for ; Mon, 17 Aug 2020 09:09:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 387B82EAF7 for ; Mon, 17 Aug 2020 09:09:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 01F4744635; Mon, 17 Aug 2020 09:09:24 +0200 (CEST) To: Proxmox VE development discussion , Alexandre DERUMIER References: <20200814144657.30063-1-a.lauterer@proxmox.com> <20200814144657.30063-2-a.lauterer@proxmox.com> <2089539399.2068990.1597647542668.JavaMail.zimbra@odiso.com> From: Aaron Lauterer Message-ID: <6f6038e3-0a02-120a-9a94-10701681f36f@proxmox.com> Date: Mon, 17 Aug 2020 09:09:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.1.1 MIME-Version: 1.0 In-Reply-To: <2089539399.2068990.1597647542668.JavaMail.zimbra@odiso.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.479 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.972 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC qemu-server 1/5] disk reassign: add API endpoint X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2020 07:09:54 -0000 On 8/17/20 8:59 AM, Alexandre DERUMIER wrote: > Hi, > > thanks for this feature, it can be really usefull. > > >>> + die "Cannot reassign disk while the source VM is running\n" >>> + if PVE::QemuServer::check_running($vmid); > > could it be possible to add support for unused disk for running vms ? > (Like this user can safely hot-unplug disk if needed, and reassign them) Good point. At the moment `unusedX` disks don't work at all due to the way I am reusing existing API schemas. I will try to get this working in the next version. :) > > > Alexandre >