From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B1B908A58 for ; Mon, 6 Mar 2023 14:16:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 89E0B1A8F for ; Mon, 6 Mar 2023 14:16:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 6 Mar 2023 14:16:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 13AD741E20; Mon, 6 Mar 2023 14:16:02 +0100 (CET) Message-ID: <6f413c3e-e56b-79be-16dd-f9989521e6a6@proxmox.com> Date: Mon, 6 Mar 2023 14:16:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Thunderbird/111.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion , John Hollowell References: <20221118013911.2655-1-jhollowe@johnhollowell.com> From: Thomas Lamprecht In-Reply-To: <20221118013911.2655-1-jhollowe@johnhollowell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series: [PATCH v2 http-server 0/2] fix #4344: ignore unused multipart headers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2023 13:16:33 -0000 Am 18/11/2022 um 02:39 schrieb John Hollowell: > This fixes an issue where an upload request without a Content-Type in > the file's multipart part would prevent the upload and throw > missleading errors. This patch removes the requirement and ignores > all multipart headers once the needed information has been extracted. > > I have tested these changes against a 7.2-11 server and both a previously > broken upload method (without the Content-Type) and using the webUI in > Chrome (which includes a Content-Type) correctly uploads the file. > > Changes since v1: > * remove `xx` and escaping of spaces from regex > > John Hollowell (2): > fix #4344: http-server: ignore unused multipart headers > Remove whitespace ignore from regex > > src/PVE/APIServer/AnyEvent.pm | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > -- > 2.30.2 > this went a bit under our radar, applied series now with some small merge conflict resolved, thanks!