From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 49689952EA for ; Mon, 26 Feb 2024 08:25:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 237B3A821 for ; Mon, 26 Feb 2024 08:25:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 26 Feb 2024 08:25:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B262470EA for ; Mon, 26 Feb 2024 08:25:15 +0100 (CET) Message-ID: <6efcd536-e9f9-47c0-9c3f-e365f3e176f7@proxmox.com> Date: Mon, 26 Feb 2024 08:25:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Fiona Ebner , Proxmox VE development discussion References: <20231121124732.2803365-1-d.csapak@proxmox.com> <20231121124732.2803365-4-d.csapak@proxmox.com> From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager v2 1/1] ui: implement 'Tag View' for the resource tree X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2024 07:25:46 -0000 On 2/16/24 15:42, Fiona Ebner wrote: > No real issues found during testing, but there is one thing that bugs > me: if I have selected a guest either: > - without tags and add a tag > or > - within the current tag group and remove that tag > then the selections for the guest is lost. Since it's the selection in > the resource view, this also affects the main area as a consequence and > feels a bit disruptive. > do you mean that you have e.g. 100 selected in the 'foo' tag group and then removed 'foo' -> select of the datacenter level? if yes, this is not easily solvable without special handle certain circumstances... e.g. consider this: vm 100 has 3 tags: foo,bar,baz you have selected it in the 'foo' group and remove the 'foo' tag which should now be selected? the entry in the 'bar' or 'baz' group? the two scenarios that i could imagine would be nice is from none -> 1 tag and reverse but sadly the tag adding code and the selection logic are rather separated, but i can think about how we could solve that thanks!