From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C150D1FF164 for <inbox@lore.proxmox.com>; Fri, 11 Apr 2025 13:14:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 38D15FA56; Fri, 11 Apr 2025 13:14:39 +0200 (CEST) Message-ID: <6ec4e5f2-773b-46cc-80e4-7fb5520c686b@proxmox.com> Date: Fri, 11 Apr 2025 13:14:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Stefan Hanreich <s.hanreich@proxmox.com> To: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>, Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Gabriel Goller <g.goller@proxmox.com> References: <20250404162908.563060-1-g.goller@proxmox.com> <20250404162908.563060-26-g.goller@proxmox.com> <9c5f591e-bf2d-4c99-ad28-02ee58bbc222@proxmox.com> <1744010542.6a4j1ll8ij.astroid@yuna.none> <ec1776b0-1a8b-45fd-bbf5-d3c96b90016b@proxmox.com> <50c0c55b-834c-4f73-b046-898584a075d5@proxmox.com> <1232290889.394.1744018049191@webmail.proxmox.com> <19fab356-828b-4aa0-adc2-b35dd3bfafda@proxmox.com> Content-Language: en-US In-Reply-To: <19fab356-828b-4aa0-adc2-b35dd3bfafda@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.664 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-access-control v2 1/1] permissions: add ACL paths for SDN fabrics X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Hit send too early when editing On 4/11/25 13:12, Stefan Hanreich wrote: > Imo, #2 and #3 seem like the contenders. #3 is what we use for zones / > vnets / subnets, and it is . #2 makes API definitions a lot nicer, [..] it is established in SDN already and works there. > since we have exactly one schema per API endpoint, which also makes > the generated API types in Rust a lot nicer. With #3 we currently > generate two structs where basically every field is an Option<T>. The > solution for this could be using oneOf across the whole API, but afaik > that is not implemented in Schema2Rust currently. Alternatively, we > could pop our own abstraction models on top of the generated types and > convert from / to them when using the API in PDM, but the real > solution is implementing oneOf support in Schema2Rust. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel