From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 907B492656 for ; Tue, 21 Mar 2023 15:04:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6EEAA1A479 for ; Tue, 21 Mar 2023 15:04:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Mar 2023 15:04:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3A8A445D27 for ; Tue, 21 Mar 2023 15:04:54 +0100 (CET) Message-ID: <6eacf96a-c3ad-b71c-131b-285b9d323b50@proxmox.com> Date: Tue, 21 Mar 2023 15:04:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US To: Proxmox VE development discussion , Thomas Lamprecht , Wolfgang Bumiller References: <20230321100425.85065-1-w.bumiller@proxmox.com> <1546649a-2aef-7262-d221-a374d670a11c@proxmox.com> From: Stefan Sterz In-Reply-To: <1546649a-2aef-7262-d221-a374d670a11c@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH 1/3] Revert "dark-theme: let the background "shine through" mask more" X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2023 14:04:56 -0000 On 3/21/23 14:05, Thomas Lamprecht wrote: > Am 21/03/2023 um 11:04 schrieb Wolfgang Bumiller: >> This looks horrible. >> >> A *much* *much* better way to improve readability is to >> simply set the opacity down to 0.5. >> >> This reverts commit 2c837f5766b48629a835c62d4b7af6c3ae4dc1c0. >> --- >> I can't stand this. >> Seriously. >> >> src/proxmox-dark/scss/extjs/_presentation.scss | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> > > applied all three patches, they actually fulfil my request to be able to still > read the stuff in the bg even a bit better and look fine enough otherwise, thanks! > > FWIW, just from a aesthetic POV the best way to make modal windows stand out would > be to blur the background, i.e.: > > .x-mask { > background-color: rgba(0,0,0,0.5); > backdrop-filter: blur(2px); > } > > (backdrop-filter + opacity doesn't work, so one needs to use rgba instead) > > But I prefer usability/accessibility over aesthetics here. > well rgba values sadly don't work properly with sassc. so that will become a solid black background. also as discussed off-list, setting the background of the mask to black looks awkward/less consistent with crisp in several situation (e.g., the retention tab of a zfs storage or the quarantine mail preview panel). however @Wolfgang and i agreed on the following: .x-mask { background-color: $background-darker; opacity: 0.5; } .x-css-shadow { box-shadow: black 0 -1px 15px 5px !important; } that should hopefully fullfill all three requirements (see-through, contrast to background, not looking strange in the given situations). > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >