From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 048D191ACF for ; Thu, 9 Feb 2023 11:34:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E235D22916 for ; Thu, 9 Feb 2023 11:34:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 9 Feb 2023 11:34:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7665044E12 for ; Thu, 9 Feb 2023 11:34:45 +0100 (CET) Message-ID: <6ea95200-6304-2060-0ac0-f14830984fc4@proxmox.com> Date: Thu, 9 Feb 2023 11:34:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20230202144135.3892582-1-d.csapak@proxmox.com> From: Aaron Lauterer In-Reply-To: <20230202144135.3892582-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.530 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.148 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v2 0/6] fix #1408: ui: make tree sorting configurable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2023 10:34:47 -0000 Had two small nits in patch 5/6. Otherwise it seems to work nicely. Tested all options and also had tags with tag overrides configured in my tests. Consider this Tested-By: Aaron Lauterer On 2/2/23 15:41, Dominik Csapak wrote: > this series allows configuring the sorting of the resource tree > > options are the sort-field, if guest types are grouped and if templates > are grouped seperately. it's configurable via browser local storage > > the first 2 patches are not really related but popped up during > development > > changes from v1: > * drop the datacenter config options for now > * rename TreeSortingEdit into TreeSortingEdit > * since we don't have a fallback besides the default, display the > defauls in the dropdowns > * don't use booleanfield anymore (because of above change) > * rename sp into localStorage > * use fieldDefaults > * refactor stuff into PVE.UIOptions (a new singleton) > * remove storage view > * remove booleanfield > > Dominik Csapak (6): > ui: remove 'Storage View' > ui: remove unused booleanfield > ui: refactor ui option related methods into UIOptions > ui: refactor refreshing the the resource store/tree > ui: add window for changing tree related options > fix #1408: ui: ResourceTree: sort the tree according to tree-sorting > options > > www/manager6/Makefile | 3 +- > www/manager6/UIOptions.js | 107 ++++++++++++++++++++++++ > www/manager6/Utils.js | 92 +------------------- > www/manager6/Workspace.js | 28 ++++++- > www/manager6/data/ResourceStore.js | 2 +- > www/manager6/dc/OptionView.js | 23 ++--- > www/manager6/form/Boolean.js | 10 --- > www/manager6/form/GlobalSearchField.js | 2 +- > www/manager6/form/Tag.js | 6 +- > www/manager6/form/TagColorGrid.js | 2 +- > www/manager6/form/TagEdit.js | 10 +-- > www/manager6/form/ViewSelector.js | 7 -- > www/manager6/tree/ResourceTree.js | 56 ++++++++++--- > www/manager6/window/TreeSettingsEdit.js | 87 +++++++++++++++++++ > 14 files changed, 289 insertions(+), 146 deletions(-) > create mode 100644 www/manager6/UIOptions.js > delete mode 100644 www/manager6/form/Boolean.js > create mode 100644 www/manager6/window/TreeSettingsEdit.js >