From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0B4D01FF183 for ; Wed, 2 Jul 2025 15:54:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F4D91C6D6; Wed, 2 Jul 2025 15:55:30 +0200 (CEST) Message-ID: <6e91c1ad-13ce-454b-a4ce-bcf1315e98ae@proxmox.com> Date: Wed, 2 Jul 2025 15:54:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Christoph Heiss References: <20250630112615.1007598-1-c.heiss@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.681 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-firewall] firewall: show full error if rule apply fails X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 7/2/25 15:53, Christoph Heiss wrote: > On Wed Jul 2, 2025 at 3:42 PM CEST, Stefan Hanreich wrote: >> On 6/30/25 13:23, Christoph Heiss wrote: >>> Currently, this will only log something like >>> >>> error updating firewall rules: cannot execute nftables commands >>> >>> which, by itself, is pretty unhelpful. `anyhow` errors have context, so >>> show that too. >> >> How much additional lines in the log would that be? > > This should not result in any extra lines, as the {:#} specifier puts > everything on one line [0]. As long as the individual messages/contexts > don't have newlines in them (which they shouldn't), of course. Ah, sorry, I was confusing it with {:?} _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel