From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3CC137878D for ; Tue, 28 Jun 2022 15:10:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3A791B779 for ; Tue, 28 Jun 2022 15:10:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 28 Jun 2022 15:10:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4986D436B4 for ; Tue, 28 Jun 2022 15:10:35 +0200 (CEST) Message-ID: <6ddfec09-beb6-b9de-2488-4a39d07d6296@proxmox.com> Date: Tue, 28 Jun 2022 15:10:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0 Content-Language: en-GB To: Fabian Ebner , pve-devel@lists.proxmox.com, Stefan Hrdlicka References: <20220622143929.2757681-1-s.hrdlicka@proxmox.com> <20220622143929.2757681-3-s.hrdlicka@proxmox.com> From: Thomas Lamprecht In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH V2 manager 2/3] cleanup: "var" to "let", fix some indentation in related files X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 13:10:37 -0000 On 28/06/2022 12:54, Fabian Ebner wrote: > Am 22.06.22 um 16:39 schrieb Stefan Hrdlicka: >> replace all "var" with "let" in files related to patch for ticket 2822 >> >> Signed-off-by: Stefan Hrdlicka > > While this patch can be fine, I think the next one is a bit too big ;) > It might introduce subtle bugs (since we might be relying on the > semantics of var somewhere) and I'd rather continue having the > conversion be done organically for a while, with patches limited in > scope (pun intended) like this one being okay. > > @Dominik, @Thomas opinions? +1 Such general and (semi-)automatable cleanups are IMO better applied by maintainers directly, they can push out a quick fix if anything is off and often are much more experienced in the code base to have a feeling where it actually has a benefit (parts seeing more churn) and how safe it is wrt. to side effects.