From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 60D9D9827A for ; Sat, 22 Apr 2023 09:21:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F8B521D9A for ; Sat, 22 Apr 2023 09:21:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 22 Apr 2023 09:21:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 996FF41E87 for ; Sat, 22 Apr 2023 09:21:40 +0200 (CEST) Message-ID: <6d9c0b3c-6eb6-cd68-4512-54bd568259ec@proxmox.com> Date: Sat, 22 Apr 2023 09:21:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak References: <20230420080616.836255-1-d.csapak@proxmox.com> <20230420080616.836255-2-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230420080616.836255-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager 2/3] ui: make storage backup content stateful X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Apr 2023 07:21:41 -0000 On 20/04/2023 10:06, Dominik Csapak wrote: > so that e.g. a custom sort/column order is saved > > Signed-off-by: Dominik Csapak > --- > www/manager6/storage/BackupView.js | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js > index 9ad1a4915..bb045f5b6 100644 > --- a/www/manager6/storage/BackupView.js > +++ b/www/manager6/storage/BackupView.js > @@ -5,6 +5,9 @@ Ext.define('PVE.storage.BackupView', { > > showColumns: ['name', 'notes', 'protected', 'date', 'format', 'size'], > > + stateful: true, > + stateId: 'storage-backup-content', I'm not the biggest fan of stateful grids, if it would only save sorting it would be OK (can easily be done, but needs to be done manual IIRC), but by default much more state is saved and reapplied. E.g. the grid column flex'd widths are then also easily made fixed. Personally I quite often use the "Reset Layout" just due to that, after having my browser resized and the columns not adapting in a responsive way – one also cannot clear the state in a fine grained way, neither by component (at least not easily by changing to a per, e.g. for here, stateful ID that includes the storage ID) nor by single thing, like sort order (e.g., a user has no simple way to know what the original sort order, deemed as best by the devs, was). > + > initComponent: function() { > let me = this; >