From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CCF717A744 for ; Tue, 5 Jul 2022 11:32:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B06B92D09E for ; Tue, 5 Jul 2022 11:32:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 5 Jul 2022 11:32:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5719640F01 for ; Tue, 5 Jul 2022 11:32:22 +0200 (CEST) Message-ID: <6d3d569f-57fe-ac85-4465-cad029cc188a@proxmox.com> Date: Tue, 5 Jul 2022 11:32:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:103.0) Gecko/20100101 Thunderbird/103.0 Content-Language: en-GB To: Proxmox VE development discussion , Aaron Lauterer References: <20220701141642.2743824-1-a.lauterer@proxmox.com> <20220701141642.2743824-2-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220701141642.2743824-2-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit 1/5] ObjectGrid: optionally show loading on reload X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2022 09:32:23 -0000 looks functional, two higher level comments inline. On 01/07/2022 16:16, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > src/grid/ObjectGrid.js | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/src/grid/ObjectGrid.js b/src/grid/ObjectGrid.js > index b355d6d..3c01851 100644 > --- a/src/grid/ObjectGrid.js > +++ b/src/grid/ObjectGrid.js > @@ -48,6 +48,8 @@ Ext.define('Proxmox.grid.ObjectGrid', { > // see top-level doc-comment above for details/example > gridRows: [], > > + showReloading: false, reloading is a bit of a misnormer and the existing `reload` fn name doesn't help, as we actually only do loads, we don't care if its the first one or a successive (re-)load one. Besides that, "showing reload" is a bit to generic, as that could also mean some loading indicator other than masking the whole component. Maybe `maskOnLoad` could be a more fitting config name for this (open for better proposals with above in mind). > + > disabled: false, > hideHeaders: true, > > @@ -221,7 +223,16 @@ Ext.define('Proxmox.grid.ObjectGrid', { > > reload: function() { > let me = this; > - me.rstore.load(); > + let param; > + if (me.showReloading) { > + me.setLoading(); > + param = { > + callback: function() { > + me.setLoading(false); > + }, > + }; I'd avoid the param variable and just to an if/else with passing the config object directly. Using an arrow fn makes it also a bit shorter, such a simple object can even be placed in a single line (but no hard feelings on that one), e.g.: me.rstore.load({ callback: () => me.setLoading(false) }); > + } > + me.rstore.load(param); > }, > > getObjectValue: function(key, defaultValue) {