From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 080BDB3DC for ; Fri, 29 Apr 2022 09:43:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 06221825C for ; Fri, 29 Apr 2022 09:43:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8F96A824F for ; Fri, 29 Apr 2022 09:43:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 67DC74302B for ; Fri, 29 Apr 2022 09:43:40 +0200 (CEST) Message-ID: <6d2195e4-5930-54ac-0190-e8bfd6c18e61@proxmox.com> Date: Fri, 29 Apr 2022 09:43:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20220429073930.727465-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220429073930.727465-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.487 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.93 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] pveceph: add ecpool create wrapper for the CLI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2022 07:43:41 -0000 On 29.04.22 09:39, Dominik Csapak wrote: > that exposes the ec options as seperate parameters instead of a format string > (for convenience). I made the ceph_pool_common_options and ec_format > public so that we can reuse them for that > > Signed-off-by: Dominik Csapak > --- > @Thomas, because you suggested something like that, but it seems a bit > out of place to me, and giving the options as property-string is not too > bad, e.g. > > pveceph pool create poolname --erasure-coding k=2,m2 > > vs > > pveceph ecpool create poolname 2 2 I mean, I'd have done: pveceph ec-pool create poolname -k 2 -m 2 which is a bit more telling than using fixed options for k/m but anyhow, you may be right in that the format string isn't to bad after all for the CLI too, and avoiding extra commands can have its merits as it reduces complexity in some way too. So its fine for me as is, minus the missing docs naturally ;-P