From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2BDC59D28C for ; Fri, 2 Jun 2023 15:10:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0C2BB2AD1D for ; Fri, 2 Jun 2023 15:10:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 2 Jun 2023 15:10:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9E68C4847F for ; Fri, 2 Jun 2023 15:10:24 +0200 (CEST) Message-ID: <6c903c4b-e105-5063-118c-882d7df2cbc9@proxmox.com> Date: Fri, 2 Jun 2023 15:10:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20230413151021.2882582-1-a.lauterer@proxmox.com> <20230413151021.2882582-3-a.lauterer@proxmox.com> <1e556951-4c24-0451-459e-802586f3aed7@proxmox.com> From: Aaron Lauterer In-Reply-To: <1e556951-4c24-0451-459e-802586f3aed7@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.1 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit 3/3] fix #3892: NetworkEdit: add bridge vids field for bridge_vids X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2023 13:10:26 -0000 On 6/1/23 16:24, Thomas Lamprecht wrote: > Don't we reuse that on PBS/PMG too, and if is it working there? > > The commit message isn't excactly telling... ;-) > on PMG we only allow creating bonds in the GUI. On PBS we allow bonds and bridges. Though that makes we wonder what the use case for a bridge on PBS is. What about safeguarding the vids to only be added/used if we are on PVE? Something like `if (PVE) {`? > > Am 13/04/2023 um 17:10 schrieb Aaron Lauterer: >> Signed-off-by: Aaron Lauterer >> --- >> src/node/NetworkEdit.js | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js >> index bb9add3..e4ab158 100644 >> --- a/src/node/NetworkEdit.js >> +++ b/src/node/NetworkEdit.js >> @@ -57,11 +57,26 @@ Ext.define('Proxmox.node.NetworkEdit', { >> } >> >> if (me.iftype === 'bridge') { >> + let vids = Ext.create('Ext.form.field.Text', { >> + fieldLabel: gettext('Bridge VIDS'), >> + name: 'bridge_vids', >> + emptyText: '2-4094', >> + disabled: true, >> + autoEl: { >> + tag: 'div', >> + 'data-qtip': gettext('Space-separated list of VLANs and ranges, for example: 2 4 100-200'), >> + }, >> + }); >> column2.push({ >> xtype: 'proxmoxcheckbox', >> fieldLabel: gettext('VLAN aware'), >> name: 'bridge_vlan_aware', >> deleteEmpty: !me.isCreate, >> + listeners: { >> + change: function(f, newVal) { >> + vids.setDisabled(!newVal); >> + }, >> + }, >> }); >> column2.push({ >> xtype: 'textfield', >> @@ -72,6 +87,7 @@ Ext.define('Proxmox.node.NetworkEdit', { >> 'data-qtip': gettext('Space-separated list of interfaces, for example: enp0s0 enp1s0'), >> }, >> }); >> + advancedColumn2.push(vids); >> } else if (me.iftype === 'OVSBridge') { >> column2.push({ >> xtype: 'textfield', >