From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B5F0C8E48B for ; Fri, 11 Nov 2022 11:27:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E7EB2655 for ; Fri, 11 Nov 2022 11:27:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 11 Nov 2022 11:27:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A6A6C43A16 for ; Fri, 11 Nov 2022 11:27:10 +0100 (CET) Message-ID: <6c5cdd75-3353-81ec-58fe-27e17b42f347@proxmox.com> Date: Fri, 11 Nov 2022 11:27:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 To: pve-devel@lists.proxmox.com References: <20220922115421.1406405-1-s.hanreich@proxmox.com> Content-Language: en-US From: Daniel Tschlatscher In-Reply-To: <20220922115421.1406405-1-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.154 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [guest-example-hookscript.pl, abstractconfig.pm] Subject: Re: [pve-devel] [PATCH pve-guest-common/pve-docs 0/1] X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2022 10:27:41 -0000 The hookscripts for pre- and post- snapshot work as intended. I tested creating snapshots in the GUI and on the CLI without finding any problems. When the hookscript fails the behavior was as I would expect it: An error in 'pre-hookscript' fails the whole task. An error in the 'post-hookscript' states that an error in the hookscript occured, but still ends with 'TASK OK', with the snapshot being created. One general suggestion: When the 'post-snapshot' hook fails it would be nice if a warning could be printed. As the snapshot still succeeds in this case, just looking at the task log list, it looks like the task finished without any problems. This would require some changes in 'exec_hookscript' and probably for other 'post-x' hooks as well, though, this is not in the scope of these patches. I just thought to put it somewhere. So, consider this series Tested-by: Daniel Tschlatscher On 9/22/22 13:54, Stefan Hanreich wrote: > This patch adds hooks that run when the user creates a snapshot from the Web UI > / CLI. I have tested this with both VMs/CTs via Web UI and CLI. Are there any > other places where the hook should get triggered that I missed? > > pve-guest-common: > > Stefan Hanreich (1): > add pre/post-snapshot hooks > > src/PVE/AbstractConfig.pm | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > pve-docs: > > Stefan Hanreich (1): > add pre/post snapshot events to example hookscript > > examples/guest-example-hookscript.pl | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >