From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E4B611FF15C for ; Wed, 30 Oct 2024 13:47:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C5E311813E; Wed, 30 Oct 2024 13:47:52 +0100 (CET) Message-ID: <6c4074f9-de2e-4e62-afd9-603f8a9b3cfd@proxmox.com> Date: Wed, 30 Oct 2024 13:47:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Timothy Nicholson References: <20241030120205.85845-1-t.nicholson@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: <20241030120205.85845-1-t.nicholson@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] fix #5810: ui: show confirmation/warning dialog for sdn apply X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 2024-10-30 13:02, Timothy Nicholson wrote: > Signed-off-by: Timothy Nicholson > --- > This patch introduces a confirmation dialog for applying the SDN configuration. As stated in the bugzilla entry [1], the main point of this dialog is to warn the user that any pending network configuration changes on the node level will also be applied. If the user clicks yes, the configuration is applied as normal. A conditional warning that states which nodes have pending changes would be nice, however this information is not readily available in the frontend, meaning there would need to be an API call for each node to find pending changes. I'll leave it open to discussion whether this would be worth it. Most of this should be part of the commit message itself, not the 'patch comment' (everything below the ---). The patch comment is discarded by `git am` when the patch is applied. It should contain information targeted at reviewers, such as open questions or the patch revision history. In the commit message, which becomes part of the commit log, you put any information about the change that is relevant in the long term, e.g. the 'why' and 'how', so that we can understand how a line of code came to be in the future. See [1] for more details. Hope this clears things up! :) [1] https://pve.proxmox.com/wiki/Developer_Documentation#Preparing_Patches > > [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=5810 > > www/manager6/sdn/StatusView.js | 26 ++++++++++++++++++-------- > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/www/manager6/sdn/StatusView.js b/www/manager6/sdn/StatusView.js > index 970aa919..46ebe69a 100644 > --- a/www/manager6/sdn/StatusView.js > +++ b/www/manager6/sdn/StatusView.js > @@ -41,14 +41,24 @@ Ext.define('PVE.sdn.StatusView', { > { > text: gettext('Apply'), > handler: function() { > - Proxmox.Utils.API2Request({ > - url: '/cluster/sdn/', > - method: 'PUT', > - waitMsgTarget: me, > - failure: function(response, opts) { > - Ext.Msg.alert(gettext('Error'), response.htmlStatus); > - }, > - }); > + Ext.Msg.show({ > + title: gettext('Confirm'), > + icon: Ext.Msg.WARNING, > + msg: gettext('Any pending node network changes will also be applied. Proceed?'), > + buttons: Ext.Msg.YESNO, > + callback: function(btn) { > + if (btn === 'yes') { > + Proxmox.Utils.API2Request({ > + url: '/cluster/sdn/', > + method: 'PUT', > + waitMsgTarget: me, > + failure: function(response, opts) { > + Ext.Msg.alert(gettext('Error'), response.htmlStatus); > + }, > + }); > + } > + } > + }) > }, > }, > ], -- - Lukas _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel