From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 622741FF380 for ; Fri, 19 Apr 2024 11:31:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C769440A9; Fri, 19 Apr 2024 11:31:44 +0200 (CEST) Message-ID: <6c3c1d27-645a-4172-b22d-3ac53a5ec052@proxmox.com> Date: Fri, 19 Apr 2024 11:31:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Fiona Ebner , Proxmox VE development discussion References: <20240409132555.364926-1-l.wagner@proxmox.com> <20240409132555.364926-2-l.wagner@proxmox.com> <95b8c12e-b959-4c4e-93b6-04e91acc3953@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox 01/19] notify: switch to file-based templating system X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 2024-04-19 10:57, Fiona Ebner wrote: > Am 19.04.24 um 10:45 schrieb Lukas Wagner: >>> Who adds the template files? I don't see a patch for proxmox-ve in this >>> series. Does this series require some versioned breaks to some package? >> >> The pve-manager and pve-ha-manager (for fencing notifications) patches add the templates. >> I can't use `/usr/share/pve-manager` and `/usr/share/pve-ha-manager` because >> proxmox_notify needs to have a single base directory from where to load template files. >> Maybe we should use some other base dir to avoid confusion with the `proxmox-ve` metapackage? >>> > Ah, I see. Yes, maybe a directory named based on libpve-notify-perl > would be better or proxmox-notify (but would need to be a bit careful > with co-installed PBS and PVE to not create accidental conflicts). mhmm. In PBS we install the templates in /usr/share/proxmox-backup/... (there it makes sense, because the templates are part of the .deb with the same name). Using `proxmox-notify` would IMO be not so good. We might have similar notification templates in both products (e.g. package-updates) which are not necessarily 100% compatible. Of course we could unify them, but I kinda prefer the flexibility of having these separate. A name based on libpve-notify implies that the templates belong to PVE, which is good. However, that only shifts the problem: pve-{ha-,}manager still install templates to a location which appears to be owned by another package, this time libpve-notify... Thinking about the options, and also about 'user experience' when adding overridable templates, I think we could just keep on using 'proxmox-ve' here. > >> In terms of versions: >> pve-{ha}-manager needs to pull in a bumped libpve-notify-perl >> libpve-notify-perl needs to pull in bumped libpve-rs-perl/libproxmox-rs-perl >> libpve-rs-perl needs to pull in bumped librust-proxmox-notify >> >> I really wish the dep-chain was a bit easier, yet here we are. >> > > But there also is a need for versioned breaks, right? Because installing > new libpve-notify-perl (using new proxmox-perl-rs using new > proxmox-notify) without also upgrading pve-manager and pve-ha-manager > will be broken or am I missing something? Ah yes, sorry, my packaging knowledge is not yet the best. A versioned break will be necessary due to the API changes (passing a template name instead of a title/body) and due to the fact that the template files must be present. -- - Lukas _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel