From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1D3CE711CE for ; Mon, 28 Jun 2021 11:46:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 077BC295F0 for ; Mon, 28 Jun 2021 11:45:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3CC32295E2 for ; Mon, 28 Jun 2021 11:45:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0370E406C5 for ; Mon, 28 Jun 2021 11:45:57 +0200 (CEST) To: pve-devel@lists.proxmox.com References: <20210624071618.21507-1-d.csapak@proxmox.com> From: Lorenz Stechauner Message-ID: <6b93ce16-35f9-b00d-b5bb-3df5d284ebe7@proxmox.com> Date: Mon, 28 Jun 2021 11:45:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210624071618.21507-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 1.544 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.765 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH widget-toolkit/manager] unify gui for task listing X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 09:46:28 -0000 Tested VM & node task log. Works as expected But found some minor inconveniences: * When a task is selected and the filter changes, therefore this task is not visible anymore, it is possible to click on the "view" button and see the previously selected task. Better behavior would be to clear the selection if the selected task is not visible anymore. * Improvement/suggestion: somehow show the task description to the user when selecting the task type (either combo box or "imgdel (Erase Data)" format?) Tested-By: Lorenz Stechauner On 24.06.21 09:16, Dominik Csapak wrote: > ports over the new task listing we have in pbs to widget-toolkit, > which is used in pve/pmg > > for this to work, the previous api series[0] must be applied, > otherwise the filter parameter do not exist > > 0: https://lists.proxmox.com/pipermail/pve-devel/2021-June/048989.html > > proxmox-widget-toolkit: > > Dominik Csapak (1): > node/Tasks: merge improvements from PBS and make it more generic > > src/css/ext6-pmx.css | 4 + > src/node/Tasks.js | 578 ++++++++++++++++++++++++++++++------------- > 2 files changed, 411 insertions(+), 171 deletions(-) > > pve-manager: > > Dominik Csapak (2): > {qemu,lxc}/Config: adapt to new proxmoxNodeTasks > ui: node/Config: add vmid filter to task lists > > www/manager6/lxc/Config.js | 4 +++- > www/manager6/node/Config.js | 8 ++++++++ > www/manager6/qemu/Config.js | 4 +++- > 3 files changed, 14 insertions(+), 2 deletions(-) >