From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3BF1C6A739 for ; Wed, 16 Mar 2022 16:24:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 282ED29746 for ; Wed, 16 Mar 2022 16:24:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B30202973C for ; Wed, 16 Mar 2022 16:24:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 855B241DC5 for ; Wed, 16 Mar 2022 16:24:07 +0100 (CET) Message-ID: <6b915aa7-838c-4acf-5f02-6c51b8be9869@proxmox.com> Date: Wed, 16 Mar 2022 16:24:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210813091012.29410-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210813091012.29410-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH v2 manager] ui: lxc options: disable features edit as non-root when container is privileged X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 15:24:38 -0000 On 13.08.21 11:10, Fabian Ebner wrote: > The backend won't allow any edits in this case, so better just disable > the edit button altogether. >=20 > Co-developed-by: Fabian Gr=C3=BCnbichler > Signed-off-by: Fabian Ebner > --- >=20 > Changes from v1: > * split cases based on 'key' > * keep logic for {dis,en}abling edit button for features in one > place >=20 > www/manager6/lxc/Options.js | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) >=20 > applied, thanks!