From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A87999EBF for ; Wed, 27 Apr 2022 12:02:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 987C324F22 for ; Wed, 27 Apr 2022 12:01:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id F404724F15 for ; Wed, 27 Apr 2022 12:01:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C596842885 for ; Wed, 27 Apr 2022 12:01:39 +0200 (CEST) Message-ID: <6b2df114-d719-4b6e-4668-9768c642d1ad@proxmox.com> Date: Wed, 27 Apr 2022 12:01:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox VE development discussion , Matthias Heiserer References: <20220316113418.748393-1-m.heiserer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220316113418.748393-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.955 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.857 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH widget-toolkit V2] ComboGrid: fix sorting when filtering X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2022 10:02:10 -0000 On 16.03.22 12:34, Matthias Heiserer wrote: > When clicking on a column to sort it, the filter doesn't reset. > Previously, it forgot the filter until the value was changed. > > Signed-off-by: Matthias Heiserer > --- > Changes from v1: > Introduce a config property to (en|dis)disable clearing the filter nit, ant I don't want to be annoying, but can you please add a empty line below, and maybe even above the series-change log for easier visibility? I'd at least appreciate that quite a bit, thx! > src/form/ComboGrid.js | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js > index 33c1d75..fa1078d 100644 > --- a/src/form/ComboGrid.js > +++ b/src/form/ComboGrid.js > @@ -12,6 +12,9 @@ Ext.define('Proxmox.form.ComboGrid', { > > // this value is used as default value after load() > preferredValue: undefined, > + clearFilterOnBlur: false, this changes the default of an ExtJS config that is used in other context though? > + clearFilterOnExit: true, > + > > // hack: allow to select empty value > // seems extjs does not allow that when 'editable == false' > @@ -470,4 +473,12 @@ Ext.define('Proxmox.form.ComboGrid', { > } > }); > }, > + > + listeners: { > + collapse: function() { > + if (this.clearFilterOnExit) { > + this.clearLocalFilter(); > + } > + }, > + }, > });