From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9B89D1FF391 for ; Wed, 12 Jun 2024 15:51:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 96C6512266; Wed, 12 Jun 2024 15:52:21 +0200 (CEST) Message-ID: <6b08ed91-e229-492e-b0fc-516b1138217c@proxmox.com> Date: Wed, 12 Jun 2024 15:51:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Dominik Csapak References: <20240424110358.2024238-1-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240424110358.2024238-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] ui: fix pbs storage edit reset behavior X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 24.04.24 um 13:03 schrieb Dominik Csapak: > two similar things to fix here: > * the 'crypt-allow-edit' field was not submitted, but it's value was > only ever set with a bind, so a reset always set it to it's > default 'false' value (disabling the radio buttons, even when > it was not visible) > > * the initial value of the 'keep' variant of the radiofield was decided > only from 'isCreate' (via the 'checked' cbind), but should have been > decided by whether there was an encryption key or not. > > both are fixed by setting the values in the 'setValue' method > explicitly > > Signed-off-by: Dominik Csapak Reviewed-by: Fiona Ebner Tested-by: Fiona Ebner _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel