From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BECA91FF13F for ; Thu, 26 Feb 2026 13:04:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E8BF91E17A; Thu, 26 Feb 2026 13:05:23 +0100 (CET) Message-ID: <6ac7fe41-29f9-4dda-bb6a-46cbca836484@proxmox.com> Date: Thu, 26 Feb 2026 13:04:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v2 2/3] agent: file-read: Allow maintaining base64-encoding of content To: Markus Ebner , pve-devel@lists.proxmox.com References: <20260225112851.124188-1-info@ebner-markus.de> <20260225112851.124188-3-info@ebner-markus.de> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260225112851.124188-3-info@ebner-markus.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772107470578 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.618 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.734 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.78 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PVMBR6ORZRG62LFEJ4LHJWBNW2WDHUFK X-Message-ID-Hash: PVMBR6ORZRG62LFEJ4LHJWBNW2WDHUFK X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 25.02.26 um 1:06 PM schrieb Markus Ebner: > The previous implementation always decoded the base64-encoded content > received from the qemu-guest-agent file-read call. Since JSON strings > must be comliant unicode text, binary data got escaped using unicode > escape sequences, using the pattern: \u00XX - with XX being the hex > value of the byte to encode. For certain binary files, this lead to a > massively inflated payload size of the API response. > > Comparison on my test system: > For a 4MiB test-file generated using > dd if=/dev/urandom bs=4M count=1 > > - Reading it with decode=1 transfers 8.61MiB and takes 5700ms on avg. > - Reading it with decode=0 transfers 5.59MiB and takes 3300ms on avg. > > To be backwards compatible, the decode parameter defaults to 1. > > Signed-off-by: Markus Ebner Reviewed-by: Fiona Ebner