From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E0E6C8E5AD for ; Fri, 11 Nov 2022 16:24:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE95D59C4 for ; Fri, 11 Nov 2022 16:24:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 11 Nov 2022 16:24:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E626343626 for ; Fri, 11 Nov 2022 16:24:15 +0100 (CET) Message-ID: <6a75c10d-1052-7fc2-88bf-27d40b301c8c@proxmox.com> Date: Fri, 11 Nov 2022 16:24:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Content-Language: en-US To: Stefan Hanreich , Proxmox VE development discussion References: <20221020152236.371434-1-m.limbeck@proxmox.com> From: Mira Limbeck In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.250 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 qemu-server] fix #4201: delete cloud-init disk on rollback X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2022 15:24:16 -0000 On 11/11/22 16:18, Stefan Hanreich wrote: > Test Setup: > I created a new VM, without any Cloud-Init drive, and immediately > created a snapshot. Then I setup a Cloud-Init drive according to the > PVE documentation via CLI. I created another snapshot of this state > with a Cloud-Init drive. > > What I tested: > - Rolling back to the older snapshot without Cloud-Init drive, it got > successfully removed. > - Rolling back to the newer snapshot that includes a Cloud-Init drive, > it successfully showed up afterwards. > > I also tested both of those cases with Cloud-Init drives created from > the Web UI, in case there are any differences. > > Some additional tests including normal CD-ROM drives I did as well - > just in case: > - Rolled back from a snapshot with only a Cloud-Init drive to a > snapshot that contains only a CD-ROM drive, the CD-ROM drive showed up > afterwards and removed the Cloud-Init drive successfully > - Rolled back from a snapshot with only a CD-ROM drive to a state that > contains only a Cloud-Init drive, the Cloud-Init drive showed up > afterwards and removed the CD-ROM drive successfully > > > Code LGTM > > > Reviewed-by: Stefan Hanreich > Tested-by: Stefan Hanreich > Thanks for testing! Since it requires a rebase, I'll send a rebased v3 with your R-b and T-b tags.