From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A66131FF16B for ; Thu, 6 Mar 2025 17:43:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B9BEDC274; Thu, 6 Mar 2025 17:43:21 +0100 (CET) Message-ID: <69f9cb45-d0e3-4b28-8773-b7a8faa02dfe@proxmox.com> Date: Thu, 6 Mar 2025 17:42:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Dominik Csapak References: <20250213131716.3062383-1-d.csapak@proxmox.com> <20250213131716.3062383-6-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250213131716.3062383-6-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu-server v6 02/10] migrate: call vm_stop_cleanup after stopping in phase3_cleanup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 13.02.25 um 14:17 schrieb Dominik Csapak: > we currently only call deactivate_volumes, but we actually want to call > the whole vm_stop_cleanup, since that is not invoked by the vm_stop > above (we cannot parse the config anymore) and might do other cleanups > we also want to do (like mdev cleanup). > > For this to work properly we have to clone the original config at the > beginning, since we might modify the volids. > > Signed-off-by: Dominik Csapak applied, thanks! It seems like other callers with nocheck are affected by this too? Namely, live-restore upon failure and the remote_migration in some cases (see the mtunnel API endpoint) also won't clean up the PCI devices etc. IIUC, or am I missing something? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel