From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 826D61FF14C for ; Fri, 15 May 2026 11:22:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5C2FF1331E; Fri, 15 May 2026 11:22:09 +0200 (CEST) Message-ID: <68cc4b68-c583-4e63-b261-6e73e4143af7@proxmox.com> Date: Fri, 15 May 2026 11:21:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: superseded: [PATCH manager v2 0/3] ui: split out disks and nics into grids From: Dominik Csapak To: pve-devel@lists.proxmox.com References: <20260508134110.4001168-1-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: <20260508134110.4001168-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778836888938 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SAQOWIR3VCRUFRLVXTFQFQXDY2FNSBCZ X-Message-ID-Hash: SAQOWIR3VCRUFRLVXTFQFQXDY2FNSBCZ X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: superseded by v3: https://lore.proxmox.com/pve-devel/20260515085349.1123127-1-d.csapak@proxmox.com/ On 5/8/26 3:39 PM, Dominik Csapak wrote: > Resending with @Davids comments fixed, sending qemu only for now again, > still working on the lxc side. > > see commit message 3/3 for details and rationale > > changes from v1: > * refactor some regexes/checks > * fix some bugs I encountered during testing again > > Dominik Csapak (3): > ui: utils: factor out 'media=cdrom' check > ui: factor out the guest key nic regex check > ui: qemu hardware view: split out disks and nics into grids > > www/manager6/Utils.js | 16 +- > www/manager6/button/Revert.js | 2 +- > www/manager6/lxc/Network.js | 4 +- > www/manager6/qemu/BootOrderEdit.js | 12 +- > www/manager6/qemu/CreateWizard.js | 4 +- > www/manager6/qemu/HardwareView.js | 557 +++++++++++++++++++++++++++-- > www/manager6/window/GuestImport.js | 2 +- > 7 files changed, 555 insertions(+), 42 deletions(-) >