From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BB2F47119A for ; Tue, 17 May 2022 16:01:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AB50D29E54 for ; Tue, 17 May 2022 16:01:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8474129E46 for ; Tue, 17 May 2022 16:01:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 44A6E43689; Tue, 17 May 2022 16:01:16 +0200 (CEST) Message-ID: <687e8bfb-cee3-9a1e-f5fc-c68081456e75@proxmox.com> Date: Tue, 17 May 2022 16:01:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Thunderbird/101.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20220517125845.2701788-1-a.lauterer@proxmox.com> From: Dominik Csapak In-Reply-To: <20220517125845.2701788-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.319 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.401 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [rbdplugin.pm] Subject: Re: [pve-devel] [PATCH storage] rbd: fix #4060 show data-pool usage when configured X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2022 14:01:47 -0000 On 5/17/22 14:58, Aaron Lauterer wrote: > When a data-pool is configured, use it for status infos. The 'data-pool' > config option is used to mark the erasure coded pool while the 'pool' > will be the replicated pool holding meta data such as the omap. > > This means, the 'pool' will only use a small amount of space and people > are interested how much they can store in the erasure coded pool anyway. > > Signed-off-by: Aaron Lauterer > --- > I decided to check for the IMO more likely case first and check against > a configured data-pool. Afterwards check if we actually need to set the > default pool name in case the pool property is omitted in the storage > config. > > PVE/Storage/RBDPlugin.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm > index fb48c3f..da28e8a 100644 > --- a/PVE/Storage/RBDPlugin.pm > +++ b/PVE/Storage/RBDPlugin.pm > @@ -630,7 +630,8 @@ sub status { > my $rados = $librados_connect->($scfg, $storeid); > my $df = $rados->mon_command({ prefix => 'df', format => 'json' }); > > - my $pool = $scfg->{pool} ? $scfg->{pool} : 'rbd'; > + my $pool = $scfg->{'data-pool'} ? $scfg->{'data-pool'} : $scfg->{pool}; > + $pool = 'rbd' if !$pool; > > my ($d) = grep { $_->{name} eq $pool } @{$df->{pools}}; > without looking more closely at the surrounding code and how we set/get those properties, wouldn't it also possble to do: my $pool = $scfg->{'data-pool'} // $scfg->{pool} // 'rbd'; ?