From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F2EB368EB3 for ; Mon, 22 Feb 2021 14:41:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F0EA6A0B5 for ; Mon, 22 Feb 2021 14:41:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 81B2EA0A8 for ; Mon, 22 Feb 2021 14:41:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4A4B044950 for ; Mon, 22 Feb 2021 14:41:34 +0100 (CET) Message-ID: <683c2ed0-99c8-7a09-ac95-d97ef8f5a73e@proxmox.com> Date: Mon, 22 Feb 2021 14:41:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20210222101626.19240-1-a.lauterer@proxmox.com> <20210222101626.19240-2-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210222101626.19240-2-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.057 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager 2/2] ui: FirewallRules: Add tooltip to comments X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Feb 2021 13:41:35 -0000 On 22.02.21 11:16, Aaron Lauterer wrote: > The comment columns might not be wide enough for longer comments. Since > it is the most right columns, it can be tricky to grab the right pixel > to drag it wider. > > A tooltip that shows up on hover should be okay. > > Signed-off-by: Aaron Lauterer > --- > > As an additional patch as I realized that the comment column can be a > bit hard to use on smaller screens. I fixed a style nit and bug and added a heuristic to only add it when required (i.e., text length is ~ longer than cell width) in a followup. > > www/manager6/grid/FirewallRules.js | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js > index 5a2241a0..f7f304b8 100644 > --- a/www/manager6/grid/FirewallRules.js > +++ b/www/manager6/grid/FirewallRules.js > @@ -763,8 +763,10 @@ Ext.define('PVE.FirewallRules', { > dataIndex: 'comment', > flex: 6, > renderer: function(value, metaData, record) { > - return render_errors('comment', Ext.util.Format.htmlEncode(value), metaData, record); > - }, > + let comment = render_errors('comment', Ext.util.Format.htmlEncode(value), metaData, record); > + return `${comment}`; returned literally "undefined" if no comment was set > +}, bad indentation > + > }, > ); > >