From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0020D6AC72 for ; Thu, 17 Mar 2022 11:35:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E962920D0 for ; Thu, 17 Mar 2022 11:35:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8602A20C7 for ; Thu, 17 Mar 2022 11:35:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5610746E85 for ; Thu, 17 Mar 2022 11:35:55 +0100 (CET) Message-ID: <682fb137-0981-0e7b-aa7b-709bced7e8cb@proxmox.com> Date: Thu, 17 Mar 2022 11:35:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: pve-devel@lists.proxmox.com, =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20220309100919.31512-1-f.ebner@proxmox.com> <20220309100919.31512-8-f.ebner@proxmox.com> <1647262537.el5ineow9k.astroid@nora.none> From: Fabian Ebner In-Reply-To: <1647262537.el5ineow9k.astroid@nora.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.121 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v12 qemu-server 07/16] clone disk: allow cloning from an unused or unreferenced disk X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 10:35:56 -0000 Am 14.03.22 um 16:55 schrieb Fabian Grünbichler: > On March 9, 2022 11:09 am, Fabian Ebner wrote: > corresponding to this else branch here - mirroring but changing > drivename is not something we currently ever want to do, so we might > want to guard against it? > Actually, it does happen when importing to a different drive key from a running VM. We don't switch the original drive node in QEMU when the target VM ID is different (like for regular clone). But there is a problematic corner case when importing from the same VM to itself ;). I'll add a check with that considered.