From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AD144742F3 for ; Sun, 18 Apr 2021 16:50:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9C8E7C6A7 for ; Sun, 18 Apr 2021 16:50:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 83F48C69A for ; Sun, 18 Apr 2021 16:50:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 46BBC42D9D for ; Sun, 18 Apr 2021 16:50:47 +0200 (CEST) Message-ID: <68185944-e3c5-d081-536b-683050d4ed3b@proxmox.com> Date: Sun, 18 Apr 2021 16:50:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20210402101923.13050-1-a.lauterer@proxmox.com> <20210402101923.13050-4-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210402101923.13050-4-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.040 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v6 qemu-server 3/5] cli: disk reassign: add reassign_disk to qm command X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 14:50:51 -0000 On 02.04.21 12:19, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > v5 -> v6: nothing > v4 -> v5: renamed `drive_key` to `drive_name` > v3 ->v4: nothing > v2 -> v3: renamed parameter `disk` to `drive_key` > rfc -> v1 -> v2: nothing changed > PVE/CLI/qm.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm > index f8972bd..36ae8e7 100755 > --- a/PVE/CLI/qm.pm > +++ b/PVE/CLI/qm.pm > @@ -914,6 +914,8 @@ our $cmddef = { > > move_disk => [ "PVE::API2::Qemu", 'move_vm_disk', ['vmid', 'disk', 'storage'], { node => $nodename }, $upid_exit ], > > + reassign_disk => [ "PVE::API2::Qemu", 'reassign_vm_disk', ['vmid', 'target_vmid', 'drive_name'], { node => $nodename } ], no new commands/params with underscore as separator please. We can actually do s/move_disk/move-disk/ for above in a separate patch and add an alias for the old one: move_disk => { alias => 'move-disk' }, > + > unlink => [ "PVE::API2::Qemu", 'unlink', ['vmid'], { node => $nodename } ], > > config => [ "PVE::API2::Qemu", 'vm_config', ['vmid'], >