From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8D7279DB96 for ; Tue, 6 Jun 2023 08:28:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 67760301B3 for ; Tue, 6 Jun 2023 08:27:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 6 Jun 2023 08:27:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B552948B8F for ; Tue, 6 Jun 2023 08:27:31 +0200 (CEST) Message-ID: <680696ea-d313-36ea-f4d1-1a79d2fc678d@proxmox.com> Date: Tue, 6 Jun 2023 08:27:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: Thomas Lamprecht , Proxmox VE development discussion References: <20230605154313.181289-1-f.ebner@proxmox.com> <20230605154313.181289-4-f.ebner@proxmox.com> <8f4a9aed-6c8a-6943-a54a-04416fd78106@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <8f4a9aed-6c8a-6943-a54a-04416fd78106@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.094 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH/RFC widget-toolkit 2/5] apt repositories: just ignore unknown info rather than throwing an error X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2023 06:28:02 -0000 Am 05.06.23 um 19:06 schrieb Thomas Lamprecht: > Am 05/06/2023 um 17:43 schrieb Fiona Ebner: >> This will avoid breaking older UI when extending the backend. >> >> Signed-off-by: Fiona Ebner >> --- >> src/node/APTRepositories.js | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js >> index cb08bb6..ed58e5b 100644 >> --- a/src/node/APTRepositories.js >> +++ b/src/node/APTRepositories.js >> @@ -660,8 +660,6 @@ Ext.define('Proxmox.node.APTRepositories', { >> if (!repoGrid.majorUpgradeAllowed) { >> infos[path][idx].warnings.push(info); >> } >> - } else { >> - throw 'unknown info'; > > otherwise we could use some Ext.Msg or at least log via console.warn (maybe it helps detecting > a missing thing someday), would both not break UI. > Yes, console.warn might be the best, because the message is indicating an internal error and not very relevant to users.