From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8D0F47C90C for ; Fri, 5 Nov 2021 14:12:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F4BACDDF for ; Fri, 5 Nov 2021 14:12:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7E28CCDD1 for ; Fri, 5 Nov 2021 14:12:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 49E7345033 for ; Fri, 5 Nov 2021 14:12:17 +0100 (CET) Message-ID: <67a3068b-50f7-f0a3-f947-e2723081fa65@proxmox.com> Date: Fri, 5 Nov 2021 14:12:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20211105130611.212658-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211105130611.212658-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.210 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.093 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] cfg2cmd: turn smm off when SeaBIOS and serial display are used X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2021 13:12:18 -0000 On 05.11.21 14:06, Fabian Ebner wrote: > Since commit 277d33454f77ec1d1e0bc04e37621e4dd2424b67 in pve-qemu, > smm=off is no longer the default, but with SeaBIOS and serial display, > this can lead to a boot loop. > > Reported in the community forum [0] and reproduced with a Debian 10 > VM. > > [0]: https://forum.proxmox.com/threads/pve-7-0-all-vms-with-cloud-init-seabios-fail-during-boot-process-bootloop-disk-not-found.97310/post-427129 > > Signed-off-by: Fabian Ebner > --- > PVE/QemuServer.pm | 12 ++++++++++ > test/cfg2cmd/seabios_serial.conf | 16 ++++++++++++++ > test/cfg2cmd/seabios_serial.conf.cmd | 33 ++++++++++++++++++++++++++++ > 3 files changed, 61 insertions(+) > create mode 100644 test/cfg2cmd/seabios_serial.conf > create mode 100644 test/cfg2cmd/seabios_serial.conf.cmd > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 763c412..9b76512 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -3403,6 +3403,16 @@ my sub get_cpuunits { > my ($conf) = @_; > return $conf->{cpuunits} // (PVE::CGroup::cgroup_mode() == 2 ? 100 : 1024); > } > + > +# Since commit 277d33454f77ec1d1e0bc04e37621e4dd2424b67 in pve-qemu, smm is not off by default > +# anymore. But smm=off seems to be required when using SeaBIOS and serial display. > +my sub should_disable_smm { > + my ($conf, $vga) = @_; > + > + return (!defined($conf->{bios}) || $conf->{bios} eq 'seabios') && > + $vga->{type} && $vga->{type} =~ m/^serial\d+$/; > +} > + > sub config_to_command { > my ($storecfg, $vmid, $conf, $defaults, $forcemachine, $forcecpu, > $pbs_backing) = @_; > @@ -4002,6 +4012,8 @@ sub config_to_command { > push @$machineFlags, 'accel=tcg'; > } > > + push @$machineFlags, 'smm=off' if should_disable_smm($conf, $vga); doesn't that breaks live migration or do we know that it could never work with smm=on under seabios + display=serial, so that there can no running VM that could be live migrated?