From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 59F3D75791 for ; Tue, 13 Jul 2021 06:42:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 464161C080 for ; Tue, 13 Jul 2021 06:42:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D47911C072 for ; Tue, 13 Jul 2021 06:42:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A913B409D1; Tue, 13 Jul 2021 06:42:03 +0200 (CEST) Message-ID: <6788b7d7-f389-606b-b117-d72b0c585b4d@proxmox.com> Date: Tue, 13 Jul 2021 06:41:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Alexandre Derumier References: <20210711224833.66035-1-aderumier@odiso.com> From: Thomas Lamprecht In-Reply-To: <20210711224833.66035-1-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.199 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.479 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [subnets.pm, vnets.pm] Subject: Re: [pve-devel] [PATCH pve-network] vnet/subnet : add skipdns option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 04:42:34 -0000 On 12.07.21 00:48, Alexandre Derumier wrote: > allow to register ip to ipam without dns registration. > can be used for temp/pending ip for example > > Signed-off-by: Alexandre Derumier > --- > PVE/Network/SDN/Subnets.pm | 70 ++++++++++++++++++++++---------------- > PVE/Network/SDN/Vnets.pm | 16 ++++----- > 2 files changed, 49 insertions(+), 37 deletions(-) > looks OK, I wonder if we'd be more future proof if we went for adding a %param hash (or as reference with $param) instead, with the skip dns options as property? Not to sure how much change potential there's here. btw., did you checked out newer ifupdown2 already? I saw that upstream added a changelog entry already, but not yet tagged as release.