From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3D33762049 for ; Wed, 19 Jan 2022 13:21:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2DB1118634 for ; Wed, 19 Jan 2022 13:21:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 62A0B18626 for ; Wed, 19 Jan 2022 13:21:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2292D457A3 for ; Wed, 19 Jan 2022 13:21:42 +0100 (CET) Date: Wed, 19 Jan 2022 13:21:41 +0100 (CET) From: Markus Frank To: Proxmox VE development discussion Message-ID: <678344591.1922.1642594901255@webmail.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.5-Rev34 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH access-control 1/1] fix #3748 changed regex-pattern to accept escape sequences on Comma X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2022 12:21:43 -0000 Correction: Patch for access-control and not for container > On 19.01.2022 13:04 markus frank wrote: > > > old-pattern: '\w+=[^,]+(,\s*\w+=[^,]+)*' > the old pattern didn't allow LDAP base domain name to be like: dc=first\, second, dc=com > new-pattern: qr(\w+=([^,\\]|\\,)+(,\s*\w+=([^,\\]|\\,)+)*), > > --- > src/PVE/Auth/LDAP.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/PVE/Auth/LDAP.pm b/src/PVE/Auth/LDAP.pm > index 97d0778..ad23cb2 100755 > --- a/src/PVE/Auth/LDAP.pm > +++ b/src/PVE/Auth/LDAP.pm > @@ -19,7 +19,7 @@ sub properties { > base_dn => { > description => "LDAP base domain name", > type => 'string', > - pattern => '\w+=[^,]+(,\s*\w+=[^,]+)*', > + pattern => qr(\w+=([^,\\]|\\,)+(,\s*\w+=([^,\\]|\\,)+)*), > optional => 1, > maxLength => 256, > }, > @@ -33,7 +33,7 @@ sub properties { > bind_dn => { > description => "LDAP bind domain name", > type => 'string', > - pattern => '\w+=[^,]+(,\s*\w+=[^,]+)*', > + pattern => qr(\w+=([^,\\]|\\,)+(,\s*\w+=([^,\\]|\\,)+)*), > optional => 1, > maxLength => 256, > }, > @@ -91,7 +91,7 @@ sub properties { > description => "LDAP base domain name for group sync. If not set, the" > ." base_dn will be used.", > type => 'string', > - pattern => '\w+=[^,]+(,\s*\w+=[^,]+)*', > + pattern => qr(\w+=([^,\\]|\\,)+(,\s*\w+=([^,\\]|\\,)+)*), > optional => 1, > maxLength => 256, > }, > -- > 2.30.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel